Fix ComponentGovernance running on public PR/CI jobs #99898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to be a side-effect of dotnet#99179 Arcade checks whether `disableComponentGovernance` is the empty string to apply the default skipping logic: https://github.com/dotnet/arcade/blob/ace00d8719b8d1fdfd0cc05f71bb9af216338d27/eng/common/templates/job/job.yml#L168-L174 Changed our templates to make sure we pass that correctly.
Contributor
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
akoeplinger
commented
Mar 18, 2024
| pool: ${{ parameters.pool }} | ||
|
|
||
| # Disable component governance if requested or on musl machines where it does not work well | ||
| ${{ if or(eq(parameters.disableComponentGovernance, true), eq(parameters.osSubGroup, '_musl')) }}: |
Member
Author
There was a problem hiding this comment.
This .yml doesn't have a disableComponentGovernance parameter and nothing sets it so I removed the check
Member
There was a problem hiding this comment.
Is that a result of the refactoring? I added a bunch of these in #84683 (though not to this file)
Member
Author
There was a problem hiding this comment.
I haven't checked but could be yeah.
jkoritzinsky
approved these changes
Mar 18, 2024
Member
Author
|
/ba-g test failures are unrelated |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be a side-effect of #99179
Arcade checks whether
disableComponentGovernanceis the empty string to apply the default skipping logic: https://github.com/dotnet/arcade/blob/ace00d8719b8d1fdfd0cc05f71bb9af216338d27/eng/common/templates/job/job.yml#L168-L174Changed our templates to make sure we pass that correctly.