Skip to content

Conversation

@rzikm
Copy link
Member

@rzikm rzikm commented Mar 14, 2024

The associated issue #70981 has been already closed.

@rzikm rzikm requested a review from wfurt March 14, 2024 16:19
Copy link
Member

@MihaZupan MihaZupan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming CI is happy, LGTM

Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rzikm
Copy link
Member Author

rzikm commented Mar 15, 2024

CI seems to be happy

https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-99769-merge-436622a9426b497e9b/System.Net.Security.Tests/1/console.eabb982f.log?helixlogtype=result

Console log: 'System.Net.Security.Tests' from job 436622a9-426b-497e-9bc8-f3c9abd19bee workitem 6d11287f-d5ac-4af1-a31b-420aa92e162f (osx.1200.amd64.open) executed on machine dci-mac-build-336.local running macOS-12.7.2
+ export __TestArchitecture=x64
+ __TestArchitecture=x64
+ find /tmp/helix/working/A2EA09B5/p -name createdump
+ xargs -n 1 codesign -s - -f --preserve-metadata=entitlements
/tmp/helix/working/A2EA09B5/p/shared/Microsoft.NETCore.App/9.0.0/createdump: replacing existing signature
+ ./RunTests.sh --runtime-path /tmp/helix/working/A2EA09B5/p
========================= Begin custom configuration settings ==============================
export __IsXUnitLogCheckerSupported=1
========================== End custom configuration settings ===============================
----- start Thu Mar 14 10:43:13 PDT 2024 =============== To repro directly: =====================================================
pushd .
/tmp/helix/working/A2EA09B5/p/dotnet exec --runtimeconfig System.Net.Security.Tests.runtimeconfig.json --depsfile System.Net.Security.Tests.deps.json xunit.console.dll System.Net.Security.Tests.dll -xml testResults.xml -nologo -nocolor -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing 
popd
===========================================================================================================
/private/tmp/helix/working/A2EA09B5/w/B00B098F/e /private/tmp/helix/working/A2EA09B5/w/B00B098F/e
  Discovering: System.Net.Security.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  System.Net.Security.Tests (found 304 of 506 test cases)
  Starting:    System.Net.Security.Tests (parallel test collections = on [6 threads], stop on fail = off)
    System.Net.Security.Tests.ServerNoEncryptionTest.ServerNoEncryption_ClientPermitsNoEncryption_ConnectWithNoEncryption [SKIP]
      Condition(s) not met: "SupportsNullEncryption"
    System.Net.Security.Tests.ServerNoEncryptionTest.ServerNoEncryption_ClientRequireEncryption_NoConnect [SKIP]
      Condition(s) not met: "SupportsNullEncryption"
    System.Net.Security.Tests.SslStreamEKUTest.SslStream_SelfSignedClientEKUClientAuth_Ok [SKIP]
      Condition(s) not met: "IsRootCertificateInstalled"
    System.Net.Security.Tests.SslStreamEKUTest.SslStream_ServerEKUClientAuth_Fails [SKIP]
      Condition(s) not met: "IsRootCertificateInstalled"
    System.Net.Security.Tests.SslStreamEKUTest.SslStream_ClientEKUServerAuth_Fails [SKIP]
      Condition(s) not met: "IsRootCertificateInstalled"
    System.Net.Security.Tests.SslStreamEKUTest.SslStream_NoEKUServerAuth_Ok [SKIP]
      Condition(s) not met: "IsRootCertificateInstalled"
    System.Net.Security.Tests.SslStreamEKUTest.SslStream_NoEKUClientAuth_Ok [SKIP]
      Condition(s) not met: "IsRootCertificateInstalled"
    System.Net.Security.Tests.NegotiatedCipherSuiteTest.CipherSuitesPolicy_OnlyTls13CipherSuiteAllowedButChosenProtocolsDoesNotAllowIt_Fails [SKIP]
      Condition(s) not met: "CipherSuitesPolicyAndTls13Supported"
    System.Net.Security.Tests.SslStreamCertificateTrustTest.SslStream_SendCertificateTrust_ThrowsOnUnsupportedPlatform [SKIP]
      Condition(s) not met: "DoesNotSupportSendingCustomCANamesInTls"
    System.Net.Security.Tests.ServerRequireEncryptionTest.ServerRequireEncryption_ClientNoEncryption_NoConnect [SKIP]
      Condition(s) not met: "SupportsNullEncryption"
    System.Net.Security.Tests.ServerAllowNoEncryptionTest.ServerAllowNoEncryption_ClientNoEncryption_ConnectWithNoEncryption [SKIP]
      Condition(s) not met: "SupportsNullEncryption"
    System.Net.Security.Tests.SslStreamNetworkStreamTest.SslStream_NegotiateClientCertificateAsyncTls13_Succeeds [SKIP]
      Condition(s) not met: "SupportsTls13"
    System.Net.Security.Tests.NegotiatedCipherSuiteTest.NegotiatedCipherSuite_SslProtocolIsTls13_ShouldBeTls13 [SKIP]
      Condition(s) not met: "Tls13Supported"
    System.Net.Security.Tests.NegotiatedCipherSuiteTest.CipherSuitesPolicy_AllowOneOnOneSideTls13_Success [SKIP]
      Condition(s) not met: "CipherSuitesPolicyAndTls13Supported"
    System.Net.Security.Tests.NegotiatedCipherSuiteTest.Tls13IsSupported_GetValue_ReturnsTrue [SKIP]
      Condition(s) not met: "IsKnownPlatformSupportingTls13"
    System.Net.Security.Tests.NegotiatedCipherSuiteTest.CipherSuitesPolicy_OnlyTls13CipherSuiteAllowedOtherSideDoesNotAllowTls13_Fails [SKIP]
      Condition(s) not met: "CipherSuitesPolicyAndTls13Supported"
  Finished:    System.Net.Security.Tests
=== TEST EXECUTION SUMMARY ===
   System.Net.Security.Tests  Total: 4850, Errors: 0, Failed: 0, Skipped: 16, Time: 58.873s

@rzikm rzikm merged commit 453713a into dotnet:main Mar 15, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 14, 2024
@karelz karelz added this to the 9.0.0 milestone May 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants