Enable most SDL-required C/C++ warnings#99470
Merged
Conversation
Member
Author
|
I broke CI by triggering a manual run before sending this PR, and now the aggregator doesn't know which run to pull results from. Whoops. :) |
GrabYourPitchforks
force-pushed
the
levib/update_cmakefile
branch
from
2493b3e to
37db868
Compare
Member
Author
|
Force-pushed to abort both dueling CI runs and trigger a new clean run. |
jkotas
reviewed
Mar 9, 2024
GrabYourPitchforks
requested review from
a team,
AaronRobinsonMSFT and
janvorli
as code owners
Member
Author
|
I searched for occurrences of |
hoyosjs
approved these changes
Mar 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicitly enables most SDL-required C/C++ warnings.
Due to the work in #66154 (thanks all!), we're already clean with respect to these warnings, so all this PR does is establish a new baseline and make BinSkim happy.
Warning C4242 is newly tracked since the last time we performed this task. We are not clean with regard to this warning due to some hits in libunwind, so I've left it commented out for the time being. Will open a new issue to track compiling clean for that warning code specifically.