Skip EventSource tests if process is not elevated#99261
Merged
davmason merged 2 commits intodotnet:mainfrom Mar 5, 2024
Merged
Skip EventSource tests if process is not elevated#99261davmason merged 2 commits intodotnet:mainfrom
davmason merged 2 commits intodotnet:mainfrom
Conversation
|
Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti Issue DetailsFixes #88305 No reason to fail the test if the issue is in the machine setup.
|
3 tasks
hoyosjs
approved these changes
Mar 5, 2024
Member
|
My concern is now, will we ever get test coverage? |
Contributor
Author
|
The failure is intermittent so I think we will still have coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #88305
No reason to fail the test if the issue is in the machine setup.