[browser][MT] fix Promise cancelation race condition#99259
Merged
pavelsavara merged 6 commits intodotnet:mainfrom Mar 6, 2024
Merged
[browser][MT] fix Promise cancelation race condition#99259pavelsavara merged 6 commits intodotnet:mainfrom
pavelsavara merged 6 commits intodotnet:mainfrom
Conversation
- introduced shared memory PromiseHolderState with IsResolving state - implemeted compareExchangeI32 and use it to signal which side will resove the Promise/Task
pavelsavara
added
arch-wasm
|
Tagging subscribers to 'arch-wasm': @lewing Issue Details
Contributes to #98721
|
Member
Author
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kg
reviewed
Mar 4, 2024
...vices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSHostImplementation.Types.cs
Show resolved
Hide resolved
kg
reviewed
Mar 4, 2024
...e.InteropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSProxyContext.cs
Show resolved
Hide resolved
kg
reviewed
Mar 4, 2024
kg
reviewed
Mar 4, 2024
kg
reviewed
Mar 4, 2024
kg
reviewed
Mar 4, 2024
kg
reviewed
Mar 4, 2024
kg
approved these changes
Mar 4, 2024
This was referenced Mar 4, 2024
3 tasks
This was referenced Mar 5, 2024
This was referenced Mar 5, 2024
Member
Author
|
The CI failure is #98406 |
Member
Author
|
This didn't 100% help Log |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PromiseHolderon js side.PromiseHolderStatewithIsResolvingstatecompareExchangeI32and use it to signal which side will resolve thePromise/TaskContributes to #98721