[debugproxy] Invoke CDP endpoint to report error to telemetry #99254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @thaystg Issue DetailsAssociated with microsoft/vscode-js-debug#1961
|
mdh1418
force-pushed
the
debug_proxy_send_evaluate_expression_error_to_telemetry
branch
from
a923b99 to
cefae9b
Compare
ilonatommy
approved these changes
Mar 5, 2024
thaystg
approved these changes
Mar 5, 2024
Member
|
Perfect @mdh1418! Thanks for working on it!!! |
mdh1418
force-pushed
the
debug_proxy_send_evaluate_expression_error_to_telemetry
branch
from
acaf45c to
bee404c
Compare
mdh1418
force-pushed
the
debug_proxy_send_evaluate_expression_error_to_telemetry
branch
from
bee404c to
edd83b0
Compare
Member
Author
|
The failures are unrelated (failing in other PRs) and have a tracking issue. |
mdh1418
deleted the
debug_proxy_send_evaluate_expression_error_to_telemetry
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated with microsoft/vscode-js-debug#1961
When debugging blazorwasm applications using the BlazorDebugProxy, there are instances where the debugger itself hits an exception, such as attempting to evaluate an expression in the watch window when the debugger is paused. To capture how often users encounter such debugger exceptions, it would be helpful to send telemetry information for such events.
This PR looks to invoke the new CDP DotnetDebugger event API endpoint being added in microsoft/vscode-js-debug#1961 when expression evaluation throws an exception in the debug proxy.
example exception message send to telemetry