JIT: Deduplicate CodeGen::genJumpTable #99110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moving same code used across all architectures to common codegen should simplify things and reduce possibility of future regressions as noted in dotnet#98992.
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsMoving same code used across all architectures to common codegen should simplify things and reduce possibility of future regressions as noted in #98992. Part of #84834
|
Bajtazar
approved these changes
Feb 29, 2024
gbalykov
approved these changes
Feb 29, 2024
sirntar
approved these changes
Feb 29, 2024
jakobbotsch
reviewed
Feb 29, 2024
tomeksowi
approved these changes
Feb 29, 2024
amanasifkhalid
approved these changes
Feb 29, 2024
Contributor
amanasifkhalid
left a comment
amanasifkhalid
left a comment
There was a problem hiding this comment.
LGTM. Could you please run jitformat locally to fix the formatting issues? Thanks!
jakobbotsch
reviewed
Feb 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving same code used across all architectures to common codegen should simplify things and reduce possibility of future regressions as noted in #98992.
Part of #84834
cc @wscho77 @HJLeee @clamp03 @JongHeonChoi @t-mustafin @gbalykov @viewizard @ashaurtaev @brucehoult @sirntar @yurai007 @Bajtazar @bartlomiejko @rzsc @tomeksowi @amanasifkhalid