Remove call to InflateInterfaces that does nothing#99070
Closed
jtschuster wants to merge 1 commit intodotnet:mainfrom
Closed
Remove call to InflateInterfaces that does nothing#99070jtschuster wants to merge 1 commit intodotnet:mainfrom
jtschuster wants to merge 1 commit intodotnet:mainfrom
Conversation
ghost
added
the
area-Tools-ILLink
|
Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas Issue DetailsThe call to We should remove the Linq enumerable before we merge, but wanted to bring this up for a discussion.
|
This was referenced Feb 28, 2024
sbomer
reviewed
Feb 28, 2024
| // Foreach interface and for each newslot virtual method on the interface, try | ||
| // to find the method implementation and record it. | ||
| foreach (var interfaceImpl in type.GetInflatedInterfaces (context)) { | ||
| foreach (var interfaceImpl in type.Interfaces.Select(i => (InflatedInterface: i.InterfaceType, OriginalImpl: i))) { |
Member
There was a problem hiding this comment.
Interesting, I wonder how this is working today for generic interfaces. What if I have:
interface I<T> {
void M(T t);
}
class C : I<int> {
public void M(int i) {}
}Presumably MapInterfaceMethodsInTypeHierarchy doesn't discover this? So what is keeping C.M?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The call to
TypeReferenceExtensions.GetInflatedInterfacesis always called on aTypeDefinition, sotypeRefis never aGenericInstanceTypeand the method will always return the uninflatedInterfaceImplementation.InterfaceTypeproperty.We should remove the Linq enumerable before we merge, but wanted to bring this up for a discussion.