Add back OverridePackageId for the crossgen sfxproj #99005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
jkoritzinsky
changed the title
lewing
approved these changes
Feb 27, 2024
akoeplinger
reviewed
Feb 27, 2024
| <!-- Crossgen is not used for Mono --> | ||
| <SkipBuild Condition="'$(RuntimeFlavor)' == 'Mono'">true</SkipBuild> | ||
| <PlatformPackageType>ToolPack</PlatformPackageType> | ||
| <SharedFrameworkName>$(SharedFrameworkName).Crossgen2</SharedFrameworkName> |
Member
There was a problem hiding this comment.
I think we also need to add the PgoSuffix back:
Suggested change
| <SharedFrameworkName>$(SharedFrameworkName).Crossgen2</SharedFrameworkName> | |
| <SharedFrameworkName>$(SharedFrameworkName).Crossgen2</SharedFrameworkName> | |
| <PgoSuffix Condition="'$(PgoInstrument)' != ''">.PGO</PgoSuffix> |
Member
Author
There was a problem hiding this comment.
We don't need to add the PGO suffix back because we don't produce this package in the PGO builds.
Member
There was a problem hiding this comment.
I think what Alexander was saying is that you are reading from the PgoSuffix property again with this change but $(PgoSuffix) is nowhere defined.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the official build