Fix incorrect exception argument in DbConnectionOptions#98826
Closed
sebastienros wants to merge 1 commit intomainfrom
Closed
Fix incorrect exception argument in DbConnectionOptions#98826sebastienros wants to merge 1 commit intomainfrom
sebastienros wants to merge 1 commit intomainfrom
Conversation
ghost
assigned
stephentoub
approved these changes
Feb 22, 2024
stephentoub
reviewed
Feb 22, 2024
| if ((null != value) && value.Contains('\0')) | ||
| { | ||
| throw ADP.InvalidValue(keyword); | ||
| throw ADP.InvalidValue(value); |
Member
There was a problem hiding this comment.
Actually, why does this need to change to value? The argument here is the parameter name, right?
Member
Author
There was a problem hiding this comment.
I am actually considering that it should be nameof(value). It's expecting the parameter name, returning an ArgumentException.
Member
Author
There was a problem hiding this comment.
Unless you mean that the value of keyword should be the parameter name since it's triggered when setting the indexer and it is meant to show this as the source
Member
There was a problem hiding this comment.
Unless you mean that the value of keyword should be the parameter name since it's triggered when setting the indexer and it is meant to show this as the source
Right, I suspect that was the original intent.
This was referenced Feb 24, 2024
jeffhandley
added
the
needs-area-label
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.