Removing GT_STORE_DYN_BLK, part 1 #98733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue Detailsnull
|
Member
Author
|
I think we can actually merge it as is? Diffs are almost none. I think it makes sense to separate function change (this) and the upcoming -1000 LOC clean up to actually remove @dotnet/jit-contrib PTAL. CI failures are unrelated (happen on all PRs now) |
jakobbotsch
reviewed
Feb 21, 2024
src/coreclr/jit/importer.cpp
Outdated
| if (isVolatile) | ||
| { | ||
| // Wrap with memory barriers: full-barrier + call + load-barrier | ||
| impSpillSideEffects(true, CHECK_SPILL_ALL DEBUGARG("spilling side-effects")); |
Member
There was a problem hiding this comment.
I think this needs to be called before we pop op1, op2 and op3 -- probably need to move the pops into each of the if/else.
EgorBo
force-pushed
the
remove-dynblock
branch
from
1703607 to
44c9c76
Compare
jakobbotsch
approved these changes
Feb 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.