[NativeAOT] Use ld_classic in ILC build and in build integration #98726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dotnet#97856) * use ld_classic in ILC build and in build integration * PR feedback * Maybe fix the build for non-apple * Update src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets PR feedback Co-authored-by: Jan Kotas <[email protected]> --------- Co-authored-by: Jan Kotas <[email protected]>
ghost
assigned
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
Member
Author
|
The actual fix for the xcode 15+ linker issue is likely going to require xcode update, so we should forward port the servicing fix in the meantime. |
Member
|
The change is also a part of #98117 . I assume we just want to go ahead with a standalone fix (not a part of that change)? |
Member
Author
|
Yes, I do not think we want to wait for that change to stabilize. |
Member
|
I've run tests locally with this change and checked runtime on a machine with xcode 15.2. Everything passed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward port of #97856
Workaround for #97745