Skip to content

[NativeAOT] Fix cut & paste errors#98686

Merged
jkotas merged 3 commits intodotnet:mainfrom
filipnavara:fix-cut-and-paste
Feb 20, 2024
Merged

[NativeAOT] Fix cut & paste errors#98686
jkotas merged 3 commits intodotnet:mainfrom
filipnavara:fix-cut-and-paste

Conversation

@filipnavara
Copy link
Member

@filipnavara filipnavara commented Feb 20, 2024

No description provided.

@ghost
Copy link

ghost commented Feb 20, 2024

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: filipnavara
Assignees: -
Labels:

area-NativeAOT-coreclr
Milestone: -

MichalStrehovsky
MichalStrehovsky approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@MichalStrehovsky MichalStrehovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Btw, there's a flavor of these for EBP as well.

Feel free to cherry pick stuff from https://github.com/bflattened/runtime/pulls?q=is%3Apr+x86+is%3Aclosed. The only reason I didn't do those against dotnet/runtime is because they're mildly hacky and I didn't want to spend time cleaning it up to Jan's (and mine) standards. It's not some secret special sauce.

@filipnavara
Copy link
Member Author

filipnavara commented Feb 20, 2024 •
edited
Loading

Feel free to cherry pick stuff from https://github.com/bflattened/runtime/pulls?q=is%3Apr+x86+is%3Aclosed.

Thanks for the tip. Still not planning to work on win-x86 but I have some fixes/cleanups that are probably worth upstreaming (and yeah, the name mangling also came up).

@jkotas jkotas merged commit 2df640c into dotnet:main Feb 20, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2024
@filipnavara filipnavara deleted the fix-cut-and-paste branch April 2, 2025 19:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@MichalStrehovsky MichalStrehovsky MichalStrehovsky approved these changes

Assignees

No one assigned

Labels

area-NativeAOT-coreclr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@filipnavara @MichalStrehovsky @jkotas