Disable building Swift interop tests on macOS with Native AOT#98667
Merged
kotlarmilos merged 5 commits intodotnet:mainfrom Feb 20, 2024
Merged
Disable building Swift interop tests on macOS with Native AOT#98667kotlarmilos merged 5 commits intodotnet:mainfrom
kotlarmilos merged 5 commits intodotnet:mainfrom
Conversation
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsDescriptionThis PR disables building Swift interop tests with Native AOT. Fixes #98611
|
kotlarmilos
changed the title
filipnavara
approved these changes
Feb 19, 2024
Member
filipnavara
left a comment
filipnavara
left a comment
There was a problem hiding this comment.
I can confirm that this fixes the build. Thanks!
jkotas
reviewed
Feb 19, 2024
| @@ -4,7 +4,7 @@ | |||
| <RequiresProcessIsolation>true</RequiresProcessIsolation> | |||
| <AllowUnsafeBlocks>true</AllowUnsafeBlocks> | |||
| <!-- Tracking issue: https://github.com/dotnet/runtime/issues/93631 --> | |||
Member
There was a problem hiding this comment.
I do not think that we have plans to enable Swift interop on non-Apple platforms - the tracking issue should be only associated with CoreCLR support only. Something like:
<!-- Swift interop is supported on Apple platforms only -->
<CLRTestTargetUnsupported Condition="'$(TargetsOSX)' != 'true' and '$(TargetsAppleMobile)' != 'true'>true</CLRTestTargetUnsupported>
<!-- Tracking issue: https://github.com/dotnet/runtime/issues/93631 -->
<CLRTestTargetUnsupported Condition="'$(RuntimeFlavor)' != 'mono'"'>true</CLRTestTargetUnsupported>
jkotas
approved these changes
Feb 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR disables building Swift interop tests with Native AOT.
Re: #98651 (comment)
Fixes #98611