Skip to content

Disable Swift interop tests on macOS with Native AOT#98651

Merged
kotlarmilos merged 1 commit intodotnet:mainfrom
kotlarmilos:bugfix/swift-interop-tests
Feb 19, 2024
Merged

Disable Swift interop tests on macOS with Native AOT#98651
kotlarmilos merged 1 commit intodotnet:mainfrom
kotlarmilos:bugfix/swift-interop-tests

Conversation

@kotlarmilos
Copy link
Member

@kotlarmilos kotlarmilos commented Feb 19, 2024 •
edited
Loading

Description

This PR disables failing Swift interop tests on macOS with Native AOT. The runtime support will be introduced in subsequent PRs.

Fixes #98611

@kotlarmilos kotlarmilos added this to the 9.0.0 milestone Feb 19, 2024
@kotlarmilos kotlarmilos self-assigned this Feb 19, 2024
@ghost
Copy link

ghost commented Feb 19, 2024

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

Description

This PR disables failing Swift interop tests on macOS with Native AOT. The runtime support will be introduced in subsequent PRs.

Author: kotlarmilos
Assignees: kotlarmilos
Labels:

os-mac-os-x, area-NativeAOT-coreclr
Milestone: 9.0.0

@kotlarmilos kotlarmilos linked an issue Feb 19, 2024 that may be closed by this pull request
Swift interop tests fail to build for NativeAOT #98611
Closed
@kotlarmilos kotlarmilos merged commit b313138 into dotnet:main Feb 19, 2024
@jkotas
Copy link
Member

jkotas commented Feb 19, 2024

I do not expect that this is going to disable the tests.

Native aot is a flavor of CoreCLR. The tests on nativeaot should have been disabled by the existing ExcludeList item under <ItemGroup Condition="'$(XunitTestBinBase)' != '' and '$(RuntimeFlavor)' == 'coreclr' ">. The new item that you have added under <ItemGroup Condition="'$(XunitTestBinBase)' != '' and '$(TestBuildMode)' == 'nativeaot' and '$(RuntimeFlavor)' == 'coreclr'"> looks redundant with the existing ExcludeList item.

My guess is that the ExcludeList item does not work as expected.

@kotlarmilos
Copy link
Member Author

kotlarmilos commented Feb 19, 2024 •
edited
Loading

Ok, I will check it. I believe that the ExcludeList is used to exclude tests from running, but not from building. According to the reported issue, the test failed during the build (AOT compilation).

@kotlarmilos kotlarmilos mentioned this pull request Feb 19, 2024
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@matouskozak matouskozak matouskozak approved these changes

@filipnavara filipnavara Awaiting requested review from filipnavara

Assignees

@kotlarmilos kotlarmilos

Labels

area-NativeAOT-coreclr os-mac-os-x macOS aka OSX

Projects

None yet

Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

Swift interop tests fail to build for NativeAOT

3 participants

@kotlarmilos @jkotas @matouskozak