[browser][MT] deputy thread #98118

pavelsavara · 2024-02-07T17:39:17Z

Threading modes

described in multi-threading.md
new JSProxyContext.ThreadBlockingMode flowing from config.
- influences ThrowOnBlockingWaitOnJSInteropThread behavior
new JSProxyContext.ThreadInteropMode
- influences sychronous calls to JSImport and JSExport
- new JSProxyContext.IsPendingSynchronousCall
- new BeforeSyncJSExport and AfterSyncJSExport to recognize start/end of incoming sync JSImport call.
- new mono_wasm_invoke_jsexport_sync_send_cb calls it
- mono_wasm_install_js_worker_interop_wrapper helps with the setup of it.
- new places throw PNSE when the rules are breached
- args.CallerNativeTID to see if the JSImport caller is the same thread.
  - only set runtimeHelpers.isPendingSynchronousCall when are same
- get_caller_native_tid to read that
new JSProxyContext.MainThreadingMode
- could be used to switch off deputy thread. Not recommended.
new enums JSThreadBlockingMode and JSThreadInteropMode and MainThreadingMode

Deputy creation

new mono_wasm_create_deputy_thread
- create deputy thread and start mono VM on it
new mono_wasm_register_ui_thread
- and later attach the UI thread to Mono. We hope to avoid this in the future.

testing

there is new flavor of System.Runtime.InteropServices.JavaScript.BackgroundExec.Tests.csproj
- disabled for ST
- to run tests which really need to run from non-JS thread.
- new env variable IsWasmBackgroundExec passed to unit tests

ghost · 2024-02-07T17:39:27Z

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author:	pavelsavara
Assignees:	pavelsavara
Labels:	`arch-wasm`, `area-VM-threading-mono`, `os-browser`
Milestone:	9.0.0

pavelsavara · 2024-02-18T12:02:05Z

/azp run runtime-wasm

azure-pipelines · 2024-02-18T12:02:13Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2024-02-21T16:28:32Z

/azp run runtime-wasm

azure-pipelines · 2024-02-21T16:28:43Z

Azure Pipelines successfully started running 1 pipeline(s).

maraf · 2024-02-21T16:47:41Z

...vices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSHostImplementation.Types.cs

+            NoSyncJSInterop = 0,
+            // allow non-re-entrant synchronous blocking calls to and from JS on JSWebWorker on threads with JS interop, like JSWebWorker and Main thread.
+            // calling synchronous JSImport on thread pool or new threads is allowed.
+            SimpleSynchronousJSInterop = 1,


I think we should come with a better name (before api review?)

@lewing also didn't like it. Please come up with suggestions.

I'm voting for longer and more descriptive name, "simple" has too much meanings

SingleSynchronousCallChainJSInterop

SingleSynchronousCallJSInterop

SingleSynchronousCallJSInterop is not bad, I like it

BTW: those would not be visible on C# API, just JS config

...itTests/BackgroundExec/System.Runtime.InteropServices.JavaScript.BackgroundExec.Tests.csproj

src/mono/browser/runtime/invoke-js.ts

src/mono/browser/runtime/managed-exports.ts

pavelsavara · 2024-02-21T17:21:55Z

/azp run runtime-wasm

azure-pipelines · 2024-02-21T17:22:08Z

Azure Pipelines successfully started running 1 pipeline(s).

Active Issue dotnet#98771

pavelsavara · 2024-02-21T20:09:46Z

/azp run runtime-wasm

azure-pipelines · 2024-02-21T20:09:58Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2024-02-21T21:18:54Z

/azp run runtime-wasm

azure-pipelines · 2024-02-21T21:19:09Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara added arch-wasm WebAssembly architecture area-VM-threading-mono os-browser Browser variant of arch-wasm labels Feb 7, 2024

pavelsavara added this to the 9.0.0 milestone Feb 7, 2024

pavelsavara self-assigned this Feb 7, 2024

build-analysis bot mentioned this pull request Feb 7, 2024

[8.0] Failing to build native components #94823

Closed

pavelsavara closed this Feb 9, 2024

pavelsavara force-pushed the browser_mt_deputy branch from d3249e5 to b47568b Compare February 9, 2024 20:07

pavelsavara reopened this Feb 9, 2024

This was referenced Feb 10, 2024

[wasm] Playwright failing #94240

Closed

Tests crashing in CI with no dump: exit code 137 means SIGKILL Killed #97049

Closed

pavelsavara force-pushed the browser_mt_deputy branch 3 times, most recently from 145b59f to cf52083 Compare February 14, 2024 17:08

This comment was marked as outdated.

Sign in to view

pavelsavara force-pushed the browser_mt_deputy branch from cf52083 to f1a8883 Compare February 15, 2024 15:36

This was referenced Feb 15, 2024

System.Text.Json failing some large file tests #59678

Closed

The hosted runner encountered an error while running your job. (Error Type: Disconnect). dotnet/dnceng#1919

Closed

pavelsavara force-pushed the browser_mt_deputy branch from f1a8883 to 0baecfb Compare February 18, 2024 07:19

build-analysis bot mentioned this pull request Feb 18, 2024

[browser][MT] WebSocket is already in CLOSING or CLOSED state #97260

Closed

pavelsavara force-pushed the browser_mt_deputy branch from 978c8b8 to cdc2135 Compare February 18, 2024 11:59

build-analysis bot mentioned this pull request Feb 18, 2024

[browser][MT] RangeError: offset is out of bounds #98630

Closed

pavelsavara force-pushed the browser_mt_deputy branch 3 times, most recently from 6fe71bb to edf321d Compare February 19, 2024 17:32

build-analysis bot mentioned this pull request Feb 19, 2024

System.Net.Http.Functional.Tests.HttpMetricsTest_Http11_Async_HttpMessageInvoker Test failure #96407

Closed

pavelsavara force-pushed the browser_mt_deputy branch from 275b7e2 to ecbb5a2 Compare February 19, 2024 23:20

pavelsavara requested review from marek-safar and vargaz as code owners February 21, 2024 16:28

maraf reviewed Feb 21, 2024

View reviewed changes

pavelsavara added 2 commits February 21, 2024 17:49

fix merge

9b007bd

fix bad merge

669a7cc

maraf approved these changes Feb 21, 2024

View reviewed changes

...itTests/BackgroundExec/System.Runtime.InteropServices.JavaScript.BackgroundExec.Tests.csproj Show resolved Hide resolved

src/mono/browser/runtime/invoke-js.ts Outdated Show resolved Hide resolved

src/mono/browser/runtime/managed-exports.ts Outdated Show resolved Hide resolved

pavelsavara mentioned this pull request Feb 21, 2024

[browser][MT] Configure threads in WebAssembly SDK #98652

Open

fix ST

73e9c6a

conditional tests

eae0342

Active Issue dotnet#98771

pavelsavara requested a review from akoeplinger as a code owner February 21, 2024 19:45

more

0e566e2

fix

ae51573

pavelsavara added 2 commits February 22, 2024 07:13

Merge branch 'main' into browser_mt_deputy

2373752

put pack _XUnitBackgroundExec

515d769

pavelsavara merged commit 771afaf into dotnet:main Feb 22, 2024

pavelsavara deleted the browser_mt_deputy branch February 22, 2024 08:39

pavelsavara changed the title ~~[browser][MT] deputy~~ [browser][MT] deputy thread Feb 22, 2024

github-actions bot locked and limited conversation to collaborators Mar 24, 2024

[browser][MT] deputy thread #98118

[browser][MT] deputy thread #98118

Uh oh!

Conversation

pavelsavara commented Feb 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Threading modes

Deputy creation

testing

Uh oh!

ghost commented Feb 7, 2024

Uh oh!

This comment was marked as outdated.

pavelsavara commented Feb 18, 2024

Uh oh!

azure-pipelines bot commented Feb 18, 2024

Uh oh!

pavelsavara commented Feb 21, 2024

Uh oh!

azure-pipelines bot commented Feb 21, 2024

Uh oh!

maraf Feb 21, 2024

Choose a reason for hiding this comment

Uh oh!

pavelsavara Feb 21, 2024

Choose a reason for hiding this comment

Uh oh!

maraf Feb 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

maraf Feb 21, 2024

Choose a reason for hiding this comment

Uh oh!

pavelsavara Feb 21, 2024

Choose a reason for hiding this comment

Uh oh!

pavelsavara Feb 21, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pavelsavara commented Feb 21, 2024

Uh oh!

azure-pipelines bot commented Feb 21, 2024

Uh oh!

pavelsavara commented Feb 21, 2024

Uh oh!

azure-pipelines bot commented Feb 21, 2024

Uh oh!

pavelsavara commented Feb 21, 2024

Uh oh!

azure-pipelines bot commented Feb 21, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

pavelsavara commented Feb 7, 2024 •

edited

Loading

maraf Feb 21, 2024 •

edited

Loading