Skip to content

Fix GT_XCHG for byte on x86 #97593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
EgorBo merged 5 commits into from
Jan 29, 2024
Merged

Fix GT_XCHG for byte on x86 #97593

EgorBo merged 5 commits into from
Jan 29, 2024

Conversation

@EgorBo
Copy link
Member

@EgorBo EgorBo commented Jan 27, 2024 •
edited
Loading

Fixes #97587

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jan 27, 2024
@ghost ghost assigned EgorBo Jan 27, 2024
@ghost
Copy link

ghost commented Jan 27, 2024

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #97587 ?

Author: EgorBo
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@EgorBo EgorBo marked this pull request as ready for review January 27, 2024 15:03
@ryujit-bot
Copy link

ryujit-bot commented Jan 27, 2024

Diff results for #97593

Throughput diffs

Throughput diffs for linux/arm64 ran on windows/x64

MinOpts (-0.01% to +0.00%)
Collection PDIFF
libraries.pmi.linux.arm64.checked.mch -0.01%

Throughput diffs for windows/arm64 ran on windows/x64

MinOpts (-0.01% to +0.00%)
Collection PDIFF
libraries.pmi.windows.arm64.checked.mch -0.01%

Details here

@ryujit-bot
Copy link

ryujit-bot commented Jan 27, 2024

Diff results for #97593

Throughput diffs

Throughput diffs for windows/arm64 ran on windows/x64

MinOpts (-0.01% to +0.00%)
Collection PDIFF
libraries.pmi.windows.arm64.checked.mch -0.01%

Details here

@ryujit-bot
Copy link

ryujit-bot commented Jan 27, 2024

Diff results for #97593

Throughput diffs

Throughput diffs for windows/x86 ran on windows/x86

Overall (+0.01%)
Collection PDIFF
benchmarks.run.windows.x86.checked.mch +0.01%
benchmarks.run_pgo.windows.x86.checked.mch +0.01%
benchmarks.run_tiered.windows.x86.checked.mch +0.01%
coreclr_tests.run.windows.x86.checked.mch +0.01%
libraries.crossgen2.windows.x86.checked.mch +0.01%
libraries.pmi.windows.x86.checked.mch +0.01%
libraries_tests.run.windows.x86.Release.mch +0.01%
libraries_tests_no_tiered_compilation.run.windows.x86.Release.mch +0.01%
realworld.run.windows.x86.checked.mch +0.01%
MinOpts (+0.02% to +0.03%)
Collection PDIFF
benchmarks.run.windows.x86.checked.mch +0.02%
benchmarks.run_pgo.windows.x86.checked.mch +0.02%
benchmarks.run_tiered.windows.x86.checked.mch +0.02%
coreclr_tests.run.windows.x86.checked.mch +0.02%
libraries.crossgen2.windows.x86.checked.mch +0.02%
libraries.pmi.windows.x86.checked.mch +0.02%
libraries_tests.run.windows.x86.Release.mch +0.02%
libraries_tests_no_tiered_compilation.run.windows.x86.Release.mch +0.02%
realworld.run.windows.x86.checked.mch +0.03%
FullOpts (+0.01%)
Collection PDIFF
benchmarks.run.windows.x86.checked.mch +0.01%
benchmarks.run_pgo.windows.x86.checked.mch +0.01%
benchmarks.run_tiered.windows.x86.checked.mch +0.01%
coreclr_tests.run.windows.x86.checked.mch +0.01%
libraries.crossgen2.windows.x86.checked.mch +0.01%
libraries.pmi.windows.x86.checked.mch +0.01%
libraries_tests.run.windows.x86.Release.mch +0.01%
libraries_tests_no_tiered_compilation.run.windows.x86.Release.mch +0.01%
realworld.run.windows.x86.checked.mch +0.01%

Details here

Throughput diffs for linux/x64 ran on linux/x64

Overall (+0.02% to +0.03%)
Collection PDIFF
libraries_tests.run.linux.x64.Release.mch +0.02%
realworld.run.linux.x64.checked.mch +0.02%
benchmarks.run_pgo.linux.x64.checked.mch +0.02%
libraries.pmi.linux.x64.checked.mch +0.02%
libraries_tests_no_tiered_compilation.run.linux.x64.Release.mch +0.02%
coreclr_tests.run.linux.x64.checked.mch +0.02%
libraries.crossgen2.linux.x64.checked.mch +0.02%
benchmarks.run.linux.x64.checked.mch +0.02%
smoke_tests.nativeaot.linux.x64.checked.mch +0.02%
benchmarks.run_tiered.linux.x64.checked.mch +0.03%
MinOpts (0.00% to +0.05%)
Collection PDIFF
libraries_tests.run.linux.x64.Release.mch +0.04%
realworld.run.linux.x64.checked.mch +0.05%
benchmarks.run_pgo.linux.x64.checked.mch +0.04%
libraries.pmi.linux.x64.checked.mch +0.04%
libraries_tests_no_tiered_compilation.run.linux.x64.Release.mch +0.05%
coreclr_tests.run.linux.x64.checked.mch +0.03%
benchmarks.run.linux.x64.checked.mch +0.04%
benchmarks.run_tiered.linux.x64.checked.mch +0.04%
FullOpts (+0.02%)
Collection PDIFF
libraries_tests.run.linux.x64.Release.mch +0.02%
realworld.run.linux.x64.checked.mch +0.02%
benchmarks.run_pgo.linux.x64.checked.mch +0.02%
libraries.pmi.linux.x64.checked.mch +0.02%
libraries_tests_no_tiered_compilation.run.linux.x64.Release.mch +0.02%
coreclr_tests.run.linux.x64.checked.mch +0.02%
libraries.crossgen2.linux.x64.checked.mch +0.02%
benchmarks.run.linux.x64.checked.mch +0.02%
smoke_tests.nativeaot.linux.x64.checked.mch +0.02%
benchmarks.run_tiered.linux.x64.checked.mch +0.02%

Details here

Throughput diffs for windows/arm64 ran on windows/x64

MinOpts (-0.01% to +0.00%)
Collection PDIFF
libraries.pmi.windows.arm64.checked.mch -0.01%

Details here

@build-analysis build-analysis bot mentioned this pull request Jan 27, 2024
Closed
kunalspathak
kunalspathak approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EgorBo
Copy link
Member Author

EgorBo commented Jan 29, 2024

Merging to unblock CI, cc @dotnet/jit-contrib

The issue was introduced in #92974

@EgorBo EgorBo merged commit 0f70e9a into dotnet:main Jan 29, 2024
@EgorBo EgorBo deleted the fix-xchng-byte branch January 29, 2024 10:38
@github-actions github-actions bot locked and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@kunalspathak kunalspathak kunalspathak approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@EgorBo EgorBo

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Assertion failed 'emitVerifyEncodable(ins, size, dstReg, srcReg)' during 'Generate code'

3 participants

@EgorBo @ryujit-bot @kunalspathak