Call VariantInit to initialize variants #97349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should fix ASAN failures on Windows that were caused by VariantClear calls on uninitialized VARIANTs that happened to have a VarType that would lead to additional freeing.
jkoritzinsky
added
test-bug
ghost
assigned
Member
|
@jkoritzinsky I thought we had a bug on this, am I mistaken? |
AaronRobinsonMSFT
approved these changes
Jan 22, 2024
Member
Author
|
I couldn't find a bug for it... |
Member
|
Perhaps #96154? |
Member
Author
|
Yep you're right. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix ASAN failures on Windows that were caused by VariantClear calls on uninitialized VARIANTs that happened to have a VarType that would lead to additional freeing.
Fixes #96154