Hash code tests cleanup #97299
Merged
Hash code tests cleanup #97299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilonatommy
added
arch-wasm
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsMoving tests around after #96354 and before PR with new
|
mkhamoyan
reviewed
Jan 22, 2024
...ies/System.Runtime/tests/System.Globalization.Tests/CompareInfo/CompareInfoTests.HashCode.cs
Outdated
Show resolved
Hide resolved
...ries/System.Runtime/tests/System.Globalization.Tests/CompareInfo/CompareInfoTests.SortKey.cs
Outdated
Show resolved
Hide resolved
...ries/System.Runtime/tests/System.Globalization.Tests/CompareInfo/CompareInfoTests.SortKey.cs
Outdated
Show resolved
Hide resolved
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…eWidth`, should stay blocked.
Member
Author
|
/azp run runtime-wasm-libtests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mkhamoyan
approved these changes
Jan 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving tests around after #96354 and before PR with new
SortKeytests. We have a bunch of mixed - purpose tests inCompareInfoTests.csthat can be categorized asSortKeyorHashCode. This PR:yield return new object[] { s_invariantCompare, "igloo", "\u0130GLOO", CompareOptions.None };case, we did not testNoneat all previously.,PNSEby using InvariantHashCodeinHybridGlobalization#96354.