[browser] Fix debugger support #97213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maraf
added
arch-wasm
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsTBD Fixes #96239 TODO
|
…milar behavior for WASI
This was referenced Jan 26, 2024
# Conflicts: # src/mono/browser/runtime/loader/config.ts
…nto csproj + print debug level on runtime)
Member
Author
maraf
requested review from
akoeplinger,
ilonatommy,
lewing and
pavelsavara
as code owners
ilonatommy
reviewed
Feb 10, 2024
Co-authored-by: Ilona Tomkowicz <[email protected]>
ilonatommy
approved these changes
Feb 12, 2024
pavelsavara
reviewed
Feb 12, 2024
src/mono/browser/runtime/startup.ts
Outdated
| if (!loaderHelpers.isDebuggingSupported() || !config.resources!.pdb) { | ||
| debugLevel = 0; | ||
| } | ||
| cwraps.mono_wasm_load_runtime("unused", debugLevel); |
Member
There was a problem hiding this comment.
I don't know if mono_wasm_load_runtime is an API for somebody, but I guess we could drop the un-used param all the way to driver.c
Member
Author
There was a problem hiding this comment.
I thought it's in the unmanaged side for some reason, otherwise you would have removed it already. I'll try and we'll see 🤞
This was referenced Feb 12, 2024
maraf
added a commit
to maraf/runtime
that referenced
this pull request
Feb 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WasmDebugLevel==0set by userCopyOutputSymbolsToPublishDirectory=trueorWasmDebugLevel!=0set by userdebugLevelto mono runtime only when browser is supported for debugging, otherwise pass 0debugLevelfor all loggingFixes #96239
Fixes #94174
Fixes #93622