Set FlagNetStandard1XDependencies=true and fix issues #96795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
needs-area-label
ViktorHofer
reviewed
Jan 10, 2024
...Microsoft.Extensions.DependencyModel/tests/Microsoft.Extensions.DependencyModel.Tests.csproj
Outdated
Show resolved
Hide resolved
This was referenced Jan 11, 2024
Closed
akoeplinger
force-pushed
the
flag-ns1x-dependencies
branch
from
31bcaf0 to
4b84e81
Compare
ViktorHofer
reviewed
Jan 22, 2024
...em.Text.RegularExpressions/tests/FunctionalTests/System.Text.RegularExpressions.Tests.csproj
Outdated
Show resolved
Hide resolved
This was referenced Jan 22, 2024
# Conflicts: # eng/testing/xunit/xunit.console.targets
ViktorHofer
reviewed
Jan 24, 2024
ViktorHofer
added a commit
to ViktorHofer/roslyn
that referenced
this pull request
Jan 24, 2024
ViktorHofer
added a commit
to ViktorHofer/roslyn-sdk
that referenced
this pull request
Jan 24, 2024
Found in dotnet/runtime#96795 (comment) These packages shouldn't be referenced on modern TFMs as the types are already provided inbox by the framework.
This was referenced Jan 24, 2024
akoeplinger
requested review from
lewing,
marek-safar and
pavelsavara
as code owners
2 tasks
jaredpar
pushed a commit
to dotnet/roslyn
that referenced
this pull request
Jan 24, 2024
* Don't reference S.R.C.Unsafe in net7.0 or newer Found in dotnet/runtime#96795 (comment) * Update src/Compilers/Core/Portable/Microsoft.CodeAnalysis.csproj
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only product change is upgrading Microsoft.DiaSymReader from 1.4.0 to 2.0.0 in ILCompiler.TypeSystem.csproj, the rest are test changes.