JIT: Remove IV analysis quirk in loop cloning #96563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a few cases the IV analysis on the new loops succeeds here even when the old did not (maybe because for old loops the logic runs before flow graph changes have happened due to loop canonicalization). Remove the quirk that was preventing us from cloning these loops.
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsIn a few cases the IV analysis on the new loops succeeds here even when the old did not (maybe because for old loops the logic runs before flow graph changes have happened due to loop canonicalization). Remove the quirk that was preventing us from cloning these loops.
|
21 tasks
Member
Author
|
cc @dotnet/jit-contrib PTAL @BruceForstall |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug in
FlowGraphNaturalLoop::MatchLimit; it did not properly check limit locals for address exposure when evaluating their invariance (the old logic does that). Also support promoted struct fields (like the old logic).No diffs expected -- the diffs of the quirk here were coming from this bug in
FlowGraphNaturalLoop::MatchLimit.