-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Add extra trimming warning suppression #96327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Tagging subscribers to this area: @dotnet/area-system-reflection-emit Issue DetailsThe flow from the runtime repo is currently broken in dotnet/sdk#37653. Cc @dotnet/illink-contrib - I don't actually understand why we're not seeing this in this repo and only in the SDK repo.
|
|
@buyaa-n the |
Perhaps the live build of linker is not used consistently in the runtime repo? Linker failures in #95980 suggest that be the case. Some issues are promptly discovered when changing llinker code in runtime repo during the initial PR, some are discovered passively when SDK is updating runtime (few times a day) and the rest are discovered at very low pace when runtime is updating SDK (few times a year). |
buyaa-n
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
dotnet/runtime suppresses IL2065. I think those suppressions were supposed to be removed as part of #38033 and should be cleaned up. |
The flow from the runtime repo is currently broken in dotnet/sdk#37653.
Cc @dotnet/illink-contrib - I don't actually understand why we're not seeing this in this repo and only in the SDK repo.