Fix JSON crashinfo exception object address #96284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsThe exception object address wasn't being render correctly in the JSON crash info.
|
jkotas
approved these changes
Dec 22, 2023
src/coreclr/nativeaot/System.Private.CoreLib/src/System/CrashInfo.cs
Outdated
Show resolved
Hide resolved
mikem8361
force-pushed
the
fixcrashinfo
branch
from
3800e49 to
b1a4c5a
Compare
This was referenced Dec 23, 2023
| return false; | ||
|
|
||
| if (!WriteHexValue("address"u8, (ulong)Unsafe.AsPointer(ref exception))) | ||
| ulong address = Unsafe.As<Exception, nuint>(ref exception); |
Member
There was a problem hiding this comment.
Can the GC move the exception object between when we write this address in crashinfo and when the actual dump is generated?
Member
There was a problem hiding this comment.
Yes, it can. IIRC, it was discussed somewhere. It is not 100% reliable pattern.
The diagnostic stack likes to use it. Tracing uses in multiple places, e.g.
.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exception object address wasn't being render correctly in the JSON crash info.