Skip to content

Fix missing return in Microsoft.Bcl.TimeProvider's Task.WaitAsync #96240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tarekgh merged 2 commits into from
Dec 24, 2023
Merged

Fix missing return in Microsoft.Bcl.TimeProvider's Task.WaitAsync #96240

tarekgh merged 2 commits into from
Dec 24, 2023

Conversation

@watfordsuzy
Copy link
Contributor

@watfordsuzy watfordsuzy commented Dec 21, 2023

Found during code review.

@ghost ghost added community-contribution Indicates that the PR has been added by a community member needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Dec 21, 2023
@watfordsuzy watfordsuzy changed the title Fix missing return in Microsoft.Bcl.TimeProvider's Task.WaitAny Fix missing return in Microsoft.Bcl.TimeProvider's Task.WaitAsync Dec 21, 2023
@watfordsuzy
Copy link
Contributor Author

watfordsuzy commented Dec 21, 2023

@dotnet-policy-service agree company="Suzy"

@danmoseley danmoseley added area-System.DateTime and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Dec 21, 2023
@ghost
Copy link

ghost commented Dec 21, 2023

Tagging subscribers to this area: @dotnet/area-system-datetime
See info in area-owners.md if you want to be subscribed.

Issue Details

Found during code review.

Author: watfordsuzy
Assignees: -
Labels:

community-contribution, area-System.DateTime
Milestone: -

This was referenced Dec 22, 2023
Closed
Closed
tarekgh
tarekgh approved these changes Dec 24, 2023
View reviewed changes
Copy link
Member

@tarekgh tarekgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @watfordsuzy

@tarekgh tarekgh merged commit 73c7673 into dotnet:main Dec 24, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tarekgh tarekgh tarekgh approved these changes

Assignees

No one assigned

Labels

area-System.DateTime community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@watfordsuzy @tarekgh @danmoseley