Skip to content

[LoongArch64] change the branch's disasm-format. #96229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jakobbotsch merged 2 commits into from
Feb 6, 2024
Merged

[LoongArch64] change the branch's disasm-format. #96229

jakobbotsch merged 2 commits into from
Feb 6, 2024

Conversation

@shushanhf
Copy link
Contributor

@shushanhf shushanhf commented Dec 21, 2023

Change the branch's disasm-format in some cases.
For LoongArch64, there is no need to add iiaHasInstrCount and iiaSetInstrCount as the LoongArch64 had optimized the branch's emitting.
As the RISCV64 #96136 , the RISCV64 can also reference this PR.

BTW, after LoongArch64's Intrinsic and Native-AOT merged, I will optimize the b and bl and also amend the other branch's format. So just leave the branch's disasm-format by the addr which is useful for now debugging.
In future I will change it as the Group's ID format.

@ghost ghost added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member labels Dec 21, 2023
@ghost
Copy link

ghost commented Dec 21, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Change the branch's disasm-format in some cases.
For LoongArch64, there is no need to add iiaHasInstrCount and iiaSetInstrCount as the LoongArch64 had optimized the branch's emitting.
As the RISCV64 #96136 , the RISCV64 can also reference this PR.

BTW, after LoongArch64's Intrinsic and Native-AOT merged, I will optimize the b and bl and also amend the other branch's format. So just leave the branch's disasm-format by the addr which is useful for now debugging.
In future I will change it as the Group's ID format.

Author: shushanhf
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution
Milestone: -

@shushanhf shushanhf mentioned this pull request Dec 21, 2023
Merged
@shushanhf shushanhf force-pushed the LA_disasm_branch_format branch from 23275c0 to d308dca Compare December 21, 2023 02:16
@build-analysis build-analysis bot mentioned this pull request Dec 21, 2023
Closed
jakobbotsch
jakobbotsch approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@jakobbotsch jakobbotsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry for missing this one!

@jakobbotsch
Copy link
Member

jakobbotsch commented Feb 5, 2024

Can you please resolve the conflict?

@shushanhf shushanhf force-pushed the LA_disasm_branch_format branch from 7dcd38d to 74a0057 Compare February 6, 2024 01:56
@shushanhf
Copy link
Contributor Author

shushanhf commented Feb 6, 2024

Can you please resolve the conflict?

Thanks!
I have updated it.

@build-analysis build-analysis bot mentioned this pull request Feb 6, 2024
Closed
@ryujit-bot
Copy link

ryujit-bot commented Feb 6, 2024

Diff results for #96229

Throughput diffs

Throughput diffs for linux/arm64 ran on windows/x64

MinOpts (-0.01% to +0.00%)
Collection PDIFF
libraries.pmi.linux.arm64.checked.mch -0.01%

Throughput diffs for windows/arm64 ran on windows/x64

MinOpts (-0.00% to +0.01%)
Collection PDIFF
libraries.pmi.windows.arm64.checked.mch +0.01%

Details here

@jakobbotsch jakobbotsch merged commit a715719 into dotnet:main Feb 6, 2024
@shushanhf shushanhf deleted the LA_disasm_branch_format branch February 18, 2024 01:13
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jakobbotsch jakobbotsch jakobbotsch approved these changes

Assignees

No one assigned

Labels

arch-loongarch64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shushanhf @jakobbotsch @ryujit-bot @am11