Longer item expiry for debug builds in System.Runtime.Caching.Tests #96186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: * MonoTests.System.Runtime.Caching.MemoryCacheTestExpires5.TestCacheExpiryOrdering * MonoTests.System.Runtime.Caching.MemoryCacheTestExpires4.TestCacheShrink The tests failed intermittently due to cache item expiry on a debug testhost on weaker hardware (VisionFive 2 RISC-V board). I saw similar uses of PlatformDetection.SlowRuntimeTimeoutModifier in System.Diagnostics.Process tests.
ghost
added
area-System.Runtime.Caching
community-contribution
gbalykov
approved these changes
Dec 19, 2023
Bajtazar
approved these changes
Dec 19, 2023
sirntar
approved these changes
Dec 19, 2023
clamp03
approved these changes
Dec 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes System.Runtime.Caching.Tests:
The tests failed intermittently due to cache item expiry on a debug testhost on weaker hardware (VisionFive 2 RISC-V board). I saw similar use of PlatformDetection.SlowRuntimeTimeoutModifier in System.Diagnostics.Process tests.
Part of #84834
cc @wscho77 @HJLeee @clamp03 @JongHeonChoi @t-mustafin @gbalykov @viewizard @ashaurtaev @brucehoult @sirntar @yurai007 @Bajtazar