Skip to content

[RISC-V] Add branch label names to disasm #96057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BruceForstall merged 39 commits into from
Dec 16, 2023
Merged

[RISC-V] Add branch label names to disasm #96057

BruceForstall merged 39 commits into from
Dec 16, 2023

Conversation

@Bajtazar
Copy link
Contributor

@Bajtazar Bajtazar commented Dec 15, 2023

Exchanges the offset immediate value with label name in the conditional branches

Sample disassembly with this PR:

G_M29951_IG09:  ;; offset=0x020C
            ld             a0, 56(fp)
            beq            a0, zero, G_M29951_IG10
            ld             a0, 56(fp)
            lui            t5, 519933
            addiw          t5, t5, 512

Part of #84834
cc @wscho77 @HJLeee @clamp03 @JongHeonChoi @t-mustafin @gbalykov @viewizard @ashaurtaev @brucehoult @sirntar @yurai007 @tomeksowi

Grzegorz Czarnecki added 30 commits November 24, 2023 16:33
Implemented emitDispIns for riscv
f9f2935
Modified emitDispIns name
c5f4314
Fixed missed case
2e7104a
Added assert
6e6441f
Fixed todo
b8767cb
Added int to jitprintf
1873c0f
Added prototype of the emit disp ins
ce09c4a
Fixes in emit dis ins name
376b79b
Reinforced types
e90d883
Removed useless ifdef statement from emit
79a1797
Fixed bug in emit disp ins
99e20b2
Added release mode emit disp
f0d1dcb
Formatted riscv64
cbf60b5
[RISC-V] Added todo comment
64c7a12
[RISC-V] Applied format patch
a6fd653
[RISC-V] Undo the emit.cpp dispIns changes
30c80ae
[RISC-V] Fixed formatting
61131a6
Removed dead code
91759cd
Merge branch 'riscv-jitdisasm' into riscv-labelgen
6d8ca16
Added emitDispInsDebugOnlyInfo
d5acb3d
Merge branch 'main' into riscv-labelgen
5357df6
Added preliminary emitOutputInstrJump
0e9c8c3
Preliminary emitOutputInstrJump impl
9213d5c
TmpSave
798258d
[RISC-V] Changes after review
9bf8da0
Merge branch 'riscv-jitdisasm' into riscv-labelgen
722cb82
Fixes after merge
b19003c
Fixed comment in emmit.h
ecebd5d
Added label printing
d3c8039
Removed dead code
b8893a0
@ghost ghost added community-contribution Indicates that the PR has been added by a community member area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Dec 15, 2023
@ghost
Copy link

ghost commented Dec 15, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Exchanges the offset immediate value with label name in the conditional branches

Sample disassembly with this PR:

G_M29951_IG09:  ;; offset=0x020C
            ld             a0, 56(fp)
            beq            a0, zero, G_M29951_IG10
            ld             a0, 56(fp)
            lui            t5, 519933
            addiw          t5, t5, 512

Part of #84834
cc @wscho77 @HJLeee @clamp03 @JongHeonChoi @t-mustafin @gbalykov @viewizard @ashaurtaev @brucehoult @sirntar @yurai007 @tomeksowi

Author: Bajtazar
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution
Milestone: -

@clamp03 clamp03 added the arch-riscv Related to the RISC-V architecture label Dec 15, 2023
@JulieLeeMSFT
Copy link
Member

JulieLeeMSFT commented Dec 15, 2023

CC @BruceForstall.

@BruceForstall BruceForstall merged commit dfe5682 into dotnet:main Dec 16, 2023
@Bajtazar Bajtazar mentioned this pull request Dec 18, 2023
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@BruceForstall BruceForstall BruceForstall approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@BruceForstall BruceForstall

@Bajtazar Bajtazar

Labels

arch-riscv Related to the RISC-V architecture area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Bajtazar @JulieLeeMSFT @BruceForstall @clamp03