Skip to content

[RISC-V] Handle mod in SetThrowHelperBlocks #96056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AndyAyersMS merged 1 commit into from
Dec 15, 2023
Merged

[RISC-V] Handle mod in SetThrowHelperBlocks #96056

AndyAyersMS merged 1 commit into from
Dec 15, 2023

Conversation

@tomeksowi
Copy link
Member

@tomeksowi tomeksowi commented Dec 15, 2023

This fixes broken CLR tests after #95379

Part of #84834
cc @wscho77 @HJLeee @clamp03 @JongHeonChoi @t-mustafin @gbalykov @viewizard @ashaurtaev @brucehoult @sirntar @yurai007 @Bajtazar

cc @shushanhf as change touches LA as well

@tomeksowi @clamp03
[RISC-V] Handle mod in SetThrowHelperBlocks
ed4d9ba 
This fixes broken CLR tests after dotnet#95379

Co-authored-by: Dong-Heon Jung <[email protected]>
@ghost ghost added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member labels Dec 15, 2023
@ghost
Copy link

ghost commented Dec 15, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

This fixes broken CLR tests after #95379

Part of #84834
cc @wscho77 @HJLeee @clamp03 @JongHeonChoi @t-mustafin @gbalykov @viewizard @ashaurtaev @brucehoult @sirntar @yurai007 @Bajtazar

cc @shushanhf as change touches LA as well

Author: tomeksowi
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution
Milestone: -

@clamp03 clamp03 added the arch-riscv Related to the RISC-V architecture label Dec 15, 2023
@clamp03 clamp03 requested a review from AndyAyersMS December 15, 2023 11:48
@AndyAyersMS
Copy link
Member

AndyAyersMS commented Dec 15, 2023

Failure was a timeout. Will ignore.

@AndyAyersMS AndyAyersMS merged commit d2cbd1c into dotnet:main Dec 15, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AndyAyersMS AndyAyersMS AndyAyersMS approved these changes

+3 more reviewers

@clamp03 clamp03 clamp03 approved these changes

@yurai007 yurai007 yurai007 approved these changes

@Bajtazar Bajtazar Bajtazar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tomeksowi tomeksowi

Labels

arch-riscv Related to the RISC-V architecture area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tomeksowi @AndyAyersMS @clamp03 @yurai007 @Bajtazar