JIT: Fix BBJ_COND-related assert in OptIfConversionDsc::IfConvertDump #95934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsIn #95773, I incorrectly assumed (Note that
|
Contributor
Author
|
cc @dotnet/jit-contrib. @jakobbotsch thank you for catching this, PTAL. |
jakobbotsch
approved these changes
Dec 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #95773, I incorrectly assumed
m_startBlockwould always be aBBJ_CONDinOptIfConversionDsc::IfConvertDump, but it can be converted to aBBJ_ALWAYSbefore being dumped, thus hitting an assert whenm_startBlock->GetTrueTarget()is called. This is fixed by calling the correct target accessor method depending on the type ofm_startBlock.(Note that
IfConvertDumpis only called if dumps are enabled, hence why this assert wasn't initially hit in CI.)