Skip to content

Use workstation GC in outerloop NativeAOT libs runs#95896

Merged
MichalStrehovsky merged 2 commits intomainfrom
MichalStrehovsky-patch-1
Dec 13, 2023
Merged

Use workstation GC in outerloop NativeAOT libs runs#95896
MichalStrehovsky merged 2 commits intomainfrom
MichalStrehovsky-patch-1

Conversation

@MichalStrehovsky
Copy link
Member

Linux has a habit of overpromising memory and then underdelivering when one wants to actually use it.

Native AOT test legs often get OOM killed. For Pri-0 runs we had success switching to workstation GC that is slower, but uses less memory. Try the same for libs testing.

Cc @dotnet/ilc-contrib

Linux has a habit of overpromising memory and then underdelivering when one wants to actually use it.

Native AOT test legs often get OOM killed. For Pri-0 runs we had success switching to workstation GC that is slower, but uses less memory. Try the same for libs testing.
@ghost
Copy link

ghost commented Dec 12, 2023

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

Linux has a habit of overpromising memory and then underdelivering when one wants to actually use it.

Native AOT test legs often get OOM killed. For Pri-0 runs we had success switching to workstation GC that is slower, but uses less memory. Try the same for libs testing.

Cc @dotnet/ilc-contrib

Author: MichalStrehovsky
Assignees: -
Labels:

area-NativeAOT-coreclr

Milestone: -

@MichalStrehovsky
Copy link
Member Author

/azp run runtime-nativeaot-outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Suchiman
Copy link
Contributor

Is this a problem with or without the new memory conserving DATAS mode?

@MichalStrehovsky
Copy link
Member Author

Is this a problem with or without the new memory conserving DATAS mode?

I think it was only made default on NativeAOT+ASP.NET for whatever reason and it's opt in everywhere else, so this would be without.

@MichalStrehovsky
Copy link
Member Author

/azp run runtime-nativeaot-outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Suchiman
Copy link
Contributor

I think it was only made default on NativeAOT+ASP.NET for whatever reason and it's opt in everywhere else, so this would be without.

Might be worth a try enabling as it can cut down heap size by up to 10x in server GC mode.

@MichalStrehovsky
Copy link
Member Author

I think it was only made default on NativeAOT+ASP.NET for whatever reason and it's opt in everywhere else, so this would be without.

Might be worth a try enabling as it can cut down heap size by up to 10x in server GC mode.

Sure, but we have IlcUseServerGc already hooked up and it gets the job done. We'd need another hook for datas and it's not clear if it would be an improvement. We're running many ilc.exe instances in parallel.

@MichalStrehovsky MichalStrehovsky merged commit fe70ca6 into main Dec 13, 2023
@MichalStrehovsky MichalStrehovsky deleted the MichalStrehovsky-patch-1 branch December 13, 2023 00:17
@github-actions github-actions bot locked and limited conversation to collaborators Jan 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants