[ILLink analyzer] Move dynamic object logic into dataflow analysis#94236
Merged
sbomer merged 2 commits intodotnet:mainfrom Nov 6, 2023
Merged
[ILLink analyzer] Move dynamic object logic into dataflow analysis#94236sbomer merged 2 commits intodotnet:mainfrom
sbomer merged 2 commits intodotnet:mainfrom
Conversation
Move dynamic object handling into dataflow handling
ghost
added
linkable-framework
|
Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr, @marek-safar Issue DetailsMoves analysis of dynamic object invocations and related operations from the attribute analyzer into the dataflow analyzer. This lowers dynamic object operations into calls to methods on Adds handling of previously unimplemented operations on dynamic objects. Fixes #94057
|
This was referenced Oct 31, 2023
vitek-karas
reviewed
Nov 6, 2023
src/tools/illink/test/Mono.Linker.Tests.Cases/DataFlow/DynamicObjects.cs
Show resolved
Hide resolved
vitek-karas
reviewed
Nov 6, 2023
src/tools/illink/test/Mono.Linker.Tests.Cases/DataFlow/DynamicObjects.cs
Show resolved
Hide resolved
vitek-karas
approved these changes
Nov 6, 2023
Member
vitek-karas
left a comment
vitek-karas
left a comment
There was a problem hiding this comment.
Other than some test comment this looks good. Thanks!
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves analysis of dynamic object invocations and related operations from the attribute analyzer into the dataflow analyzer. This lowers dynamic object operations into calls to methods on
Microsoft.CSharp.RuntimeBinder.Binder, which haveRequiresUnreferencedCodeannotations, so that the analyzer produces the same warnings as ILLink.Adds handling of previously unimplemented operations on dynamic objects. Fixes #94057