[wasm] Error out for AOT with no il trimming#94064
Merged
radical merged 1 commit intodotnet:mainfrom Oct 27, 2023
Merged
Conversation
Without trimming AOT builds would be very slow, and unusable.
radical
requested review from
ilonatommy,
lewing,
maraf,
pavelsavara,
radekdoulik and
vargaz
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsWithout trimming AOT builds would be very slow, and unusable.
|
vargaz
approved these changes
Oct 26, 2023
Contributor
|
Some other cases:
|
ilonatommy
approved these changes
Oct 27, 2023
2 tasks
liveans
pushed a commit
to liveans/dotnet-runtime
that referenced
this pull request
Nov 9, 2023
Without trimming AOT builds would be very slow, and unusable.
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without trimming AOT builds would be very slow, and unusable.