Fix analyzer assert and add dynamic object tests #94058
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
linkable-framework
|
Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr, @marek-safar Issue DetailsFixes the assert from #94016. #94057 tracks adding full support for this in the analyzer. We had some existing tests that only covered IDynamicInvocationOperation. Those have been moved to a shared testcase (shared by ILLink/NativeAot), and some additional testcases have been added that include coverage for IDynamicMemberReference, which was causing the assert.
|
vitek-karas
approved these changes
Oct 26, 2023
Member
Author
|
Failure is #93522 |
liveans
pushed a commit
to liveans/dotnet-runtime
that referenced
this pull request
Nov 9, 2023
Fixes the assert from dotnet#94016. dotnet#94057 tracks adding full support for this in the analyzer. We had some existing tests that only covered IDynamicInvocationOperation. Those have been moved to a shared testcase (shared by ILLink/NativeAot), and some additional testcases have been added that include coverage for IDynamicMemberReference, which was causing the assert. This includes the same fix for IDynamicIndexerAccessOperation.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the assert from #94016. #94057 tracks adding full support for this in the analyzer.
We had some existing tests that only covered IDynamicInvocationOperation. Those have been moved to a shared testcase (shared by ILLink/NativeAot), and some additional testcases have been added that include coverage for IDynamicMemberReference, which was causing the assert.
Fixes #94016