[NativeAOT] Support library mode with NativeAOT on iOS-like platforms by ivanpovazan · Pull Request #93658 · dotnet/runtime

ivanpovazan · 2023-10-18T12:02:49Z

This PR enables support for building libraries for iOS-like platforms with NativeAOT.

Changes

Extended NativeAOT build integration targets to support building libraries for iOS-like platforms
Adapted AppleAppBuilder to support bundling in library mode for both MonoAOT and NativeAOT
Adapted AppleAppBuilder to support bundling in library mode when targeting iOS-like devices
Adapted src/tests/FunctionalTests/iOS/Simulator/LibraryMode for testing the library mode on iossimulators-arm64/x64 with NativeAOT - currently this only works locally please see comments in the project file for more info
- [NativeAOT] Enable running libraries and functional tests locally and on CI #93447)
Added src/tests/FunctionalTests/iOS/Device/LibraryMode for testing the library mode on ios-arm64 for both MonoAOT and NativeAOT

Additional notes

To test locally one can execute the following from the repo root directory:

Test MonoAOT library mode on ios-arm64:

./dotnet.sh build /t:Test -c Debug /p:TargetOS=ios /p:TargetArchitecture=arm64 src/tests/FunctionalTests/iOS/Device/LibraryMode/iOS.Device.LibraryMode.Test.csproj /p:RuntimeFlavor=Mono

Test NativeAOT library mode on ios-arm64:

./dotnet.sh build /t:Test -c Debug /p:TargetOS=ios /p:TargetArchitecture=arm64 src/tests/FunctionalTests/iOS/Device/LibraryMode/iOS.Device.LibraryMode.Test.csproj /p:UseNativeAOTRuntime=true /p:RunAOTCompilation=false /p:RuntimeFlavor=CoreCLR

Documentation

[ios][docs] Document how iOS library mode is supported #96742

Fixes #88737

ghost · 2023-10-18T12:03:19Z

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR enables support for building libraries for iOS-like platforms with NativeAOT.

Changes

Extended NativeAOT build integration targets to support building libraries for iOS-like platforms
Adapted AppleAppBuilder to support bundling in library mode for both MonoAOT and NativeAOT
Adapted AppleAppBuilder to support bundling in library mode when targeting iOS-like devices
Adapted src/tests/FunctionalTests/iOS/Simulator/LibraryMode for testing the library mode on iossimulators-arm64/x64 with NativeAOT - currently this only works locally please see comments in the project file for more info
- [NativeAOT] Enable running libraries and functional tests locally and on CI #93447)
Added src/tests/FunctionalTests/iOS/Device/LibraryMode for testing the library mode on ios-arm64 for both MonoAOT and NativeAOT

Additional notes

To test locally one can execute the following from the repo root directory:

Test MonoAOT library mode on ios-arm64:

./dotnet.sh build /t:Test -c Debug /p:TargetOS=ios /p:TargetArchitecture=arm64 src/tests/FunctionalTests/iOS/Device/LibraryMode/iOS.Device.LibraryMode.Test.csproj /p:RuntimeFlavor=Mono

Test NativeAOT library mode on ios-arm64:

./dotnet.sh build /t:Test -c Debug /p:TargetOS=ios /p:TargetArchitecture=arm64 src/tests/FunctionalTests/iOS/Device/LibraryMode/iOS.Device.LibraryMode.Test.csproj /p:UseNativeAOTRuntime=true /p:RunAOTCompilation=false /p:RuntimeFlavor=CoreCLR

Fixes #88737

Author:	ivanpovazan
Assignees:	ivanpovazan
Labels:	`area-Infrastructure-mono`
Milestone:	-

src/tasks/AppleAppBuilder/Xcode.cs

ivanpovazan · 2023-10-18T15:25:06Z

~~Failures are related:~~
~~1. Since I introduced VerifyOSSpecificTooling target, it seems I broke some dependency with tooling in the build~~
~~2. Building on Helix for the library mode tests seem to be broken~~

ivanpovazan · 2023-10-18T16:48:52Z

/azp run runtime-ioslikesimulator

azure-pipelines · 2023-10-18T16:49:05Z

Azure Pipelines successfully started running 1 pipeline(s).

src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets

global.json

ivanpovazan · 2023-11-13T21:47:52Z

/azp run runtime-ioslikesimulator

ivanpovazan · 2023-11-13T21:47:58Z

/azp run runtime-ioslike

azure-pipelines · 2023-11-13T21:48:01Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2023-11-13T21:48:08Z

Azure Pipelines successfully started running 1 pipeline(s).

ivanpovazan · 2023-11-13T22:48:31Z

/azp run runtime-ioslikesimulator

azure-pipelines · 2023-11-13T22:48:40Z

Azure Pipelines successfully started running 1 pipeline(s).

am11

Two optional nits, otherwise looks great! 👍

src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets

src/tests/FunctionalTests/iOS/Device/LibraryMode/iOS.Device.LibraryMode.Test.csproj

ivanpovazan · 2024-01-08T12:15:23Z

/azp run runtime-extra-platforms

azure-pipelines · 2024-01-08T12:15:36Z

Azure Pipelines successfully started running 1 pipeline(s).

ivanpovazan · 2024-01-08T16:25:09Z

/azp run runtime-extra-platforms

azure-pipelines · 2024-01-08T16:25:24Z

Azure Pipelines successfully started running 1 pipeline(s).

ivanpovazan · 2024-01-09T10:19:05Z

The CI failures are unrelated.

@steveisok @rolfbjarne @jkotas could you please take another look as we would like to get this in for net9.0-p1?

rolfbjarne

LGTM

jkotas · 2024-01-09T15:38:20Z

@jkotas could you please take another look as we would like to get this in for net9.0-p1?

The changes in the shared native AOT files LGTM.

MichalStrehovsky

nativeaot/BuildIntegration looks good to me too!

…dotnet#93658) Fixes dotnet#88737

ivanpovazan requested review from akoeplinger, filipnavara, jkotas and steveisok October 18, 2023 12:02

ivanpovazan self-assigned this Oct 18, 2023

ivanpovazan requested review from MichalStrehovsky and marek-safar as code owners October 18, 2023 12:02

ghost added the area-Infrastructure-mono label Oct 18, 2023

ivanpovazan requested a review from rolfbjarne October 18, 2023 12:03

rolfbjarne reviewed Oct 18, 2023

View reviewed changes

src/tasks/AppleAppBuilder/Xcode.cs Outdated Show resolved Hide resolved

build-analysis bot mentioned this pull request Oct 18, 2023

[wasm] Runtime tests failing - _Vector2_3_4::Vector2_3_4Test.RunVector*Tests because of missing support for native libraries #93669

Closed

MichalStrehovsky reviewed Oct 19, 2023

View reviewed changes

src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets Outdated Show resolved Hide resolved

ivanpovazan force-pushed the naot-ios-libmode branch from 5089847 to 2f65e3b Compare October 20, 2023 11:51

build-analysis bot mentioned this pull request Oct 20, 2023

Tracking issue for CI build timeouts #76454

Closed

ivanpovazan mentioned this pull request Oct 26, 2023

[helix][ios] Emulate deep signing of iOS app bundles on helix in order to support library mode builds dotnet/arcade#14164

Merged

ivanpovazan force-pushed the naot-ios-libmode branch from 43f2655 to 9ef633d Compare November 13, 2023 21:44

ivanpovazan commented Nov 13, 2023

View reviewed changes

global.json Outdated Show resolved Hide resolved

This was referenced Nov 14, 2023

Several XML tests are sporadically failing in CI due to OOMs #82894

Closed

[wasm] Runtime tests' build gets terminated with exited with code 137 #94077

Closed

Tracking issue for "WORKLOAD TIMED OUT" #90309

Closed

ivanpovazan requested review from MichalStrehovsky, akoeplinger, am11 and steveisok December 22, 2023 09:29

am11 approved these changes Dec 22, 2023

View reviewed changes

src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets Outdated Show resolved Hide resolved

src/tests/FunctionalTests/iOS/Device/LibraryMode/iOS.Device.LibraryMode.Test.csproj Outdated Show resolved Hide resolved

runfoapp bot mentioned this pull request Dec 22, 2023

system.text.regularexpressions.tests work item #72834

Open

This was referenced Dec 22, 2023

Android emulator not booting completely on Helix queue dotnet/dnceng#1448

Closed

System.Tests.StringTests failing on windows Release NativeAOT_Libraries leg #96279

Closed

build-analysis bot mentioned this pull request Jan 8, 2024

[mono][tvos] OOM in System.IO.Tests.MemoryStreamTests #92467

Closed

ivanpovazan added 6 commits January 8, 2024 17:18

Support library mode with NativeAOT on iOS-like platforms

e4cd60a

PR feedback

0725085

Simplifications according to the feedback

8262b02

PR feedback

9d92eba

PR feedback

3a7c402

PR feedback

22235dd

ivanpovazan force-pushed the naot-ios-libmode branch from 17e5aed to 22235dd Compare January 8, 2024 16:19

ivanpovazan mentioned this pull request Jan 9, 2024

[ios] Support bundling shared libraries into frameworks #96664

Closed

rolfbjarne approved these changes Jan 9, 2024

View reviewed changes

akoeplinger approved these changes Jan 9, 2024

View reviewed changes

MichalStrehovsky reviewed Jan 10, 2024

View reviewed changes

ivanpovazan merged commit 3f3af5e into dotnet:main Jan 10, 2024

ivanpovazan deleted the naot-ios-libmode branch January 10, 2024 08:57

tmds pushed a commit to tmds/runtime that referenced this pull request Jan 23, 2024

[NativeAOT] Support library mode with NativeAOT on iOS-like platforms (…

9eca186

…dotnet#93658) Fixes dotnet#88737

github-actions bot locked and limited conversation to collaborators Feb 10, 2024

Conversation

ivanpovazan commented Oct 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Additional notes

Documentation

Uh oh!

ghost commented Oct 18, 2023

Changes

Additional notes

Uh oh!

Uh oh!

ivanpovazan commented Oct 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ivanpovazan commented Oct 18, 2023

Uh oh!

azure-pipelines bot commented Oct 18, 2023

Uh oh!

Uh oh!

Uh oh!

ivanpovazan commented Nov 13, 2023

Uh oh!

ivanpovazan commented Nov 13, 2023

Uh oh!

azure-pipelines bot commented Nov 13, 2023

Uh oh!

azure-pipelines bot commented Nov 13, 2023

Uh oh!

ivanpovazan commented Nov 13, 2023

Uh oh!

azure-pipelines bot commented Nov 13, 2023

Uh oh!

am11 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ivanpovazan commented Jan 8, 2024

Uh oh!

azure-pipelines bot commented Jan 8, 2024

Uh oh!

ivanpovazan commented Jan 8, 2024

Uh oh!

azure-pipelines bot commented Jan 8, 2024

Uh oh!

ivanpovazan commented Jan 9, 2024

Uh oh!

rolfbjarne left a comment

Choose a reason for hiding this comment

Uh oh!

jkotas commented Jan 9, 2024

Uh oh!

MichalStrehovsky left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

ivanpovazan commented Oct 18, 2023 •

edited

Loading

ivanpovazan commented Oct 18, 2023 •

edited

Loading