Merged
Conversation
ghost
added
community-contribution
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
Tagging subscribers to this area: @dotnet/area-system-io Issue Details
|
This was referenced Oct 14, 2023
MojtabaTajik
changed the title
jozkee
reviewed
Oct 23, 2023
src/libraries/System.IO.FileSystem/tests/File/AppendAllBytes.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.IO.FileSystem/tests/File/AppendAllBytesAsync.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: David Cantú <[email protected]>
Co-authored-by: David Cantú <[email protected]>
Co-authored-by: David Cantú <[email protected]>
Co-authored-by: David Cantú <[email protected]>
Co-authored-by: David Cantú <[email protected]>
Co-authored-by: David Cantú <[email protected]>
Co-authored-by: David Cantú <[email protected]>
Co-authored-by: David Cantú <[email protected]>
Co-authored-by: David Cantú <[email protected]>
jozkee
reviewed
Oct 23, 2023
Member
jozkee
left a comment
jozkee
left a comment
There was a problem hiding this comment.
Almost there.
When you commit changes, can you please push when you have all changes ready or use the "Add suggestion to batch" in GH; each push may trigger a CI run which is more expensive than having one after all feedback is addressed.
src/libraries/System.IO.FileSystem/tests/File/AppendAllBytes.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.IO.FileSystem/tests/File/AppendAllBytesAsync.cs
Outdated
Show resolved
Hide resolved
- Remove unwanted spaces in files - Fix API documentation - Add assertation for file exists Co-authored-by: David Cantú <[email protected]>
jozkee
approved these changes
Oct 23, 2023
jozkee
reviewed
Oct 23, 2023
This was referenced Oct 23, 2023
MojtabaTajik
changed the title
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added AppendAllBytes API and the async version with the corresponding tests.
Fix #84532