@dotnet-policy-service agree

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

is this breaking change since it is touching ref assembly? I don't think the risk is high but I suspect there may be impact for somebody. Any thought @karelz?

This isn't breaking change as far as I know. cc @stephentoub

This isn't breaking change as far as I know. cc @stephentoub

Changing a property that was returning string to one that returns string? can introduce new warnings, e.g. anyone with NRT enabled and was doing:

string ua = request.UserAgent;

will now get a new warning where they didn't previously, and if they have warnings-as-errors enabled, that will break the build.

So technically it is a breaking change. In the past we've typically just had a single catch-all breaking change notification about such nullability annotation changes. @jeffhandley, is there a process in place for aggregating all of these?

With as few of these types of breaking changes as we've had recently, we should just start documenting each of them individually. I recall @gewarren mentioning the aggegate approach also introduced challenges, but I don't recall the specifics.

I'm tagging this issue as needing a breaking change doc issue created. @ManickaP, it would be best for you to file the issue per the steps that the automated comment will provide. Here's a good reference example for the issue.

Added needs-breaking-change-doc-created label because this PR has the breaking-change label.

When you commit this breaking change:

1. Create and link to this PR and the issue a matching issue in the dotnet/docs repo using the breaking change documentation template, then remove this needs-breaking-change-doc-created label.
2. Ask a committer to mail the .NET Breaking Change Notification DL.

Tagging @dotnet/compat for awareness of the breaking change.

dotnet/docs#37900

We did aggregate (most of) the nullability changes for .NET 6: https://learn.microsoft.com/en-us/dotnet/core/compatibility/core-libraries/6.0/nullable-ref-type-annotation-changes. I think it makes sense to aggregate them unless they fall under different areas.