Skip to content

Update the assert for BlendVariable #92183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kunalspathak merged 3 commits into from
Sep 20, 2023
Merged

Update the assert for BlendVariable #92183

kunalspathak merged 3 commits into from
Sep 20, 2023

Conversation

@kunalspathak
Copy link
Contributor

@kunalspathak kunalspathak commented Sep 16, 2023

For BlendVariable(), op3 should be present in XMM0. However, sometimes targetReg can get XMM0 allocated because op3 might be last use. In such case, make sure that we do not overwrite the targetReg i.e. XMM0 with op1Reg.

Fixes: #91798

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Sep 16, 2023
@ghost ghost assigned kunalspathak Sep 16, 2023
@ghost
Copy link

ghost commented Sep 16, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

For BlendVariable(), op3 should be present in XMM0. However, sometimes targetReg can get XMM0 allocated because op3 might be last use. In such case, make sure that we do not overwrite the targetReg i.e. XMM0 with op1Reg.

Fixes: #91798

Author: kunalspathak
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@kunalspathak kunalspathak marked this pull request as ready for review September 20, 2023 17:17
@kunalspathak kunalspathak merged commit b4be77b into dotnet:main Sep 20, 2023
@kunalspathak kunalspathak deleted the issue_91798 branch September 20, 2023 17:17
@rzikm rzikm mentioned this pull request Sep 26, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Oct 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tannergooding tannergooding tannergooding approved these changes

Assignees

@kunalspathak kunalspathak

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Assertion failed 'targetReg != REG_XMM0' during 'Generate code'

2 participants

@kunalspathak @tannergooding