Port the check for illegal type recursion to the EnsureLoadableType implementation#91707
Merged
davidwrighton merged 1 commit intodotnet:mainfrom Sep 7, 2023
Merged
Conversation
…mplementation - Algorithm described in ECMA 335 II.9.2 Generics and recursive inheritance graphs) - Reuse the Tarjan algorithm logic for this
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue Details
|
Member
Author
|
I don't think this is worth porting to the release branch. If we need to fix the test there, I think we should just disable the test. |
This was referenced Sep 7, 2023
trylek
approved these changes
Sep 7, 2023
Member
trylek
left a comment
trylek
left a comment
There was a problem hiding this comment.
Looks great to me, thanks David! I agree we shouldn't need to backport this change to .NET 8, after all the release branch has at least my original hotfix limiting the recursion depth.
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #89545