SPMI: Optimize collection download, increase diffs timeout #91637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the latest collections we are frequently hitting timeouts during linux asmdiffs runs. This PR applies two changes to improve the situation: - Optimize the download/extraction of collections by extracting directly to the target location. The Helix machines actually seem to spend many times longer to extract and copy the collections than they do downloading them. - Increase the timeout of superpmi-diffs by one hour.
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsWith the latest collections we are frequently hitting timeouts during
|
This reverts commit 57adc61.
Member
Author
|
cc @dotnet/jit-contrib PTAL @BruceForstall This passed CI with a JIT change in https://github.com/dotnet/runtime/pull/91637/checks?check_run_id=16522220574 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the latest collections we are frequently hitting timeouts during
linux tpdiff runs. This PR applies two changes to improve the
situation:
to the target location. The Helix machines actually seem to spend many
times longer to extract and copy the collections than they do
downloading them.