Fix diagnostic creation to ensure including the URI#91123
Fix diagnostic creation to ensure including the URI#91123tarekgh merged 2 commits intodotnet:mainfrom
Conversation
|
Tagging subscribers to this area: @dotnet/area-extensions-logging Issue DetailsThe creation of
|
|
This looks good, I just noticed one other instance of the same problem in d303781. @jkoritzinsky did you want to handle that separately, or would it make sense to add to this PR? |
|
@jkoritzinsky @ericstj I added the fix of the interop one too. |
|
/backport to release/8.0 |
|
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/5981087443 |
ghost
locked as resolved and limited conversation to collaborators
3 participants
The creation of
LoggingUnsupportedLanguageVersionin logging source gen was missing the URI link. The fix is to use the Create helper method to ensure adding the URI to the diagnostics.