Skip to content

[IGNORE][wasm] testing tfm net9.0 changes #91105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
radical wants to merge 21 commits into from
Closed

[IGNORE][wasm] testing tfm net9.0 changes #91105

radical wants to merge 21 commits into from

Conversation

@radical
Copy link
Member

@radical radical commented Aug 25, 2023 •
edited
Loading

No description provided.

@radical radical added the arch-wasm WebAssembly architecture label Aug 25, 2023
@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 25, 2023
@ghost ghost assigned radical Aug 25, 2023
@ghost
Copy link

ghost commented Aug 25, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Update TFM to net9.0
  • Fix ApiCompat failures.
  • Create a separate workload for net9 vs net8. Let's see if this fixes WASI.
  • revert all wasm changes
Author: radical
Assignees: -
Labels:

arch-wasm
Milestone: -

@radical radical changed the title net90tfm wasm [IGNORE][wasm] testing tfm net9.0 changes Aug 25, 2023
@radical radical added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it area-Build-mono and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Aug 25, 2023
@radical radical mentioned this pull request Aug 25, 2023
Merged
ViktorHofer and others added 17 commits August 25, 2023 10:08
@ViktorHofer
Remove netcoreappX.X, net6.0, net7.0 and net8.0 conditions and clean-up
5516dae
@ViktorHofer
Merge branch 'main' into net90tfm
152c332
@ViktorHofer
Fix build
49a4843
@ViktorHofer
Make projects target the right set of TFMs and order
a49cdb8
@ViktorHofer
Update assembly version
f32781e
@ViktorHofer
Remove dead property
f92050d
@radical
revert all wasm changes
b7b8bb3
@radical
[wasm] WBT: Override runtime pack with the locally built one
fcceee9
@radical
Merge branch 'main' into net90tfm
afdca7b
@radical
[wasm] Move the override targets to a separate file, and use for wasi…
1f5a55b 
… too
@radical
overwrite when copying
fcc6935
@radical
add missing file
ecadc3b
@radical
Update WebAssembly.Pack version also
718d654
@radical
fix tests
bef19e5
@radical
Disable non-wasm build tests
e070989 
Trying to get this to work for the short period till the sdk moves to
net9.0 would not be worth the effort. Failure:

```
        [] Executing (Captured Output) - /root/helix/work/workitem/e/dotnet-latest/dotnet run -c Debug -f net8.0 --no-build -  in pwd /root/helix/work/workitem/e/wbt/nonwasm_net8.0_Debug_4utlyi5x_k3s
        [] Unhandled exception. System.IO.FileNotFoundException: Could not load file or assembly 'System.Runtime, Version=9.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified.
```
@radical
Override runtime pack for multithread
41d7eb9
@radical
Fix overriding packs
5f935d5
@radical radical closed this Aug 31, 2023
@radical radical deleted the net90tfm-wasm branch August 31, 2023 20:55
@ghost ghost locked as resolved and limited conversation to collaborators Oct 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@marek-safar marek-safar Awaiting requested review from marek-safar marek-safar will be requested when the pull request is marked ready for review marek-safar is a code owner

@maraf maraf Awaiting requested review from maraf maraf will be requested when the pull request is marked ready for review maraf is a code owner

@ilonatommy ilonatommy Awaiting requested review from ilonatommy ilonatommy will be requested when the pull request is marked ready for review ilonatommy is a code owner

@lewing lewing Awaiting requested review from lewing lewing will be requested when the pull request is marked ready for review lewing is a code owner

@pavelsavara pavelsavara Awaiting requested review from pavelsavara pavelsavara will be requested when the pull request is marked ready for review pavelsavara is a code owner

@steveisok steveisok Awaiting requested review from steveisok steveisok will be requested when the pull request is marked ready for review steveisok is a code owner

@vitek-karas vitek-karas Awaiting requested review from vitek-karas vitek-karas will be requested when the pull request is marked ready for review vitek-karas is a code owner

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky will be requested when the pull request is marked ready for review MichalStrehovsky is a code owner

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

@radical radical

Labels

arch-wasm WebAssembly architecture area-Build-mono NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@radical @fanyang-mono @jkoritzinsky @ViktorHofer