Skip to content

Disable RemoteExecutor SearchValues tests on LinuxBionic#90954

Merged
MihaZupan merged 1 commit intodotnet:mainfrom
MihaZupan:searchvalues-remoteexec-bionic
Aug 24, 2023
Merged

Disable RemoteExecutor SearchValues tests on LinuxBionic#90954
MihaZupan merged 1 commit intodotnet:mainfrom
MihaZupan:searchvalues-remoteexec-bionic

Conversation

@MihaZupan
Copy link
Member

@MihaZupan MihaZupan commented Aug 22, 2023

@MihaZupan MihaZupan added this to the 9.0.0 milestone Aug 22, 2023
@MihaZupan MihaZupan self-assigned this Aug 22, 2023
@ghost
Copy link

ghost commented Aug 22, 2023

Tagging subscribers to this area: @dotnet/area-system-memory
See info in area-owners.md if you want to be subscribed.

Issue Details

Closes #90945
Context: #90945 (comment)

Similar RemoteExecutor tests are already disabled on this platform, e.g. https://github.com/dotnet/runtime/blob/6b67caaedfbfeaf7707478e50ccc9e8bc929e591/src/libraries/System.Globalization/tests/CultureInfo/GetCultureInfo.cs#L160C9-L160C100

Author: MihaZupan
Assignees: MihaZupan
Labels:

area-System.Memory
Milestone: 9.0.0

@filipnavara
Copy link
Member

filipnavara commented Aug 22, 2023

Wouldn't it make sense to condition on [ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]?

@MihaZupan
Copy link
Member Author

MihaZupan commented Aug 22, 2023 •
edited
Loading

That is what CanTestInvariantCulture already does.

I suppose it would be nicer if we turned RemoteExecutor.IsSupported off for this target in Arcade instead

@filipnavara
Copy link
Member

filipnavara commented Aug 22, 2023 •
edited
Loading

That is what CanTestInvariantCulture already does.

Two of the methods have just a Fact as far as I can see on the GitHub diff (sorry if I missed it and it's on the test class itself).

I suppose it would be nicer if we turned RemoteExecutor.IsSupported off for this target in Arcade instead

Agreed (but there's no public API to detect Linux Bionic)...

@build-analysis build-analysis bot mentioned this pull request Aug 24, 2023
Closed
@MihaZupan
Copy link
Member Author

MihaZupan commented Aug 24, 2023

@dotnet/area-system-memory can someone please approve this one to clean up the CI?

@MihaZupan MihaZupan merged commit 6882c0f into dotnet:main Aug 24, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tannergooding tannergooding tannergooding approved these changes

Assignees

@MihaZupan MihaZupan

Labels

area-System.Memory

Projects

None yet

Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

System.Memory.Tests.Span.StringSearchValuesTests failing with "Exit code was 1 but it should have been 42"

3 participants

@MihaZupan @filipnavara @tannergooding