Skip to content

[RISC-V] Fix MarshalStructAsLayoutSeq #90719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jakobbotsch merged 3 commits into from
Aug 29, 2023
Merged

[RISC-V] Fix MarshalStructAsLayoutSeq #90719

jakobbotsch merged 3 commits into from
Aug 29, 2023

Conversation

@clamp03
Copy link
Member

@clamp03 clamp03 commented Aug 17, 2023

  • Fix MarshalStructAsParam_AsSeqByValFixedBufferClassificationTest
  • Fix MarshalStructAsParam_AsSeqByValUnicodeCharArrayClassification
    Ex. Argument in struct { int a, int b, float c} type should be passed with two integer registers (not one integer register and one float register).

Part of #84834
cc @wscho77 @HJLeee @JongHeonChoi @t-mustafin @alpencolt @gbalykov @tomeksowi

@clamp03
[RISC-V] Fix MarshalStructAsLayoutSeq
aa38298 
- Fix MarshalStructAsParam_AsSeqByValFixedBufferClassificationTest
- Fix MarshalStructAsParam_AsSeqByValUnicodeCharArrayClassification
@ghost ghost added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member labels Aug 17, 2023
@clamp03 clamp03 self-assigned this Aug 17, 2023
@ghost
Copy link

ghost commented Aug 17, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Fix MarshalStructAsParam_AsSeqByValFixedBufferClassificationTest
  • Fix MarshalStructAsParam_AsSeqByValUnicodeCharArrayClassification
    Ex. Argument in struct { int a, int b, float c} type should be passed with two integer registers (not one integer register and one float register).

Part of #84834
cc @wscho77 @HJLeee @JongHeonChoi @t-mustafin @alpencolt @gbalykov @tomeksowi

Author: clamp03
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@clamp03 clamp03 added the arch-riscv Related to the RISC-V architecture label Aug 17, 2023
@build-analysis build-analysis bot mentioned this pull request Aug 17, 2023
Closed
@clamp03 clamp03 marked this pull request as ready for review August 18, 2023 02:24
@clamp03
Copy link
Member Author

clamp03 commented Aug 23, 2023

@jakobbotsch Could you take a look at this PR? Thank you so much.

jakobbotsch
jakobbotsch reviewed Aug 24, 2023
View reviewed changes
@jakobbotsch jakobbotsch merged commit f175acf into dotnet:main Aug 29, 2023
@clamp03 clamp03 deleted the fixmarshal branch August 30, 2023 10:56
@ghost ghost locked as resolved and limited conversation to collaborators Sep 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jakobbotsch jakobbotsch jakobbotsch approved these changes

+3 more reviewers

@tomeksowi tomeksowi tomeksowi approved these changes

@alpencolt alpencolt alpencolt approved these changes

@t-mustafin t-mustafin t-mustafin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@clamp03 clamp03

Labels

arch-riscv Related to the RISC-V architecture area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@clamp03 @tomeksowi @alpencolt @jakobbotsch @t-mustafin