Improve filtering of candidate binding invocations in config binder gen #90619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 15, 2023
|
Tagging subscribers to this area: @dotnet/area-extensions-configuration Issue DetailsAddress #89587 (comment).
|
layomia
force-pushed
the
binder-gen-parsing
branch
from
2630523 to
969f192
Compare
layomia
force-pushed
the
binder-gen-parsing
branch
from
969f192 to
28ec242
Compare
src/libraries/Microsoft.Extensions.Configuration.Binder/gen/Helpers/Parser/BinderInvocation.cs
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.Configuration.Binder/gen/Helpers/Parser/BinderInvocation.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.Configuration.Binder/gen/Helpers/Parser/BinderInvocation.cs
Outdated
Show resolved
Hide resolved
Member
eiriktsarpalis
left a comment
eiriktsarpalis
left a comment
There was a problem hiding this comment.
Structurally the change looks good, but I had a few questions about the details.
layomia
force-pushed
the
binder-gen-parsing
branch
2 times, most recently
from
48c4762 to
31a561a
Compare
layomia
force-pushed
the
binder-gen-parsing
branch
from
31a561a to
81bf579
Compare
src/libraries/Microsoft.Extensions.Configuration.Binder/gen/Helpers/Parser/BinderInvocation.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.Configuration.Binder/gen/Helpers/Parser/BinderInvocation.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.Configuration.Binder/gen/Helpers/Parser/BinderInvocation.cs
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.Configuration.Binder/gen/Helpers/Parser/BinderInvocation.cs
Outdated
Show resolved
Hide resolved
Contributor
Author
Contributor
Author
|
/backport to release/8.0-rc1 |
Contributor
|
Started backporting to release/8.0-rc1: https://github.com/dotnet/runtime/actions/runs/5892715423 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #89587 (comment).