Skip to content

[Experiment] Post loop unrolling phase#90591

Closed
hez2010 wants to merge 2 commits intodotnet:mainfrom
hez2010:post-loop-unrolling
Closed

[Experiment] Post loop unrolling phase#90591
hez2010 wants to merge 2 commits intodotnet:mainfrom
hez2010:post-loop-unrolling

Conversation

@hez2010
Copy link
Contributor

@hez2010 hez2010 commented Aug 15, 2023

No description provided.

@ghost ghost added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member labels Aug 15, 2023
@ghost
Copy link

ghost commented Aug 15, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: hez2010
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@EgorBo
Copy link
Member

EgorBo commented Aug 15, 2023

As per discussion in Discord, if you want to land something like this you will need to make OptRepeatCount robust alone without any changes. Currently, DOTNET_OptRepeatCount=x will trigger lots of asserts everywhere, you might avoid them if you limit your opts to some specific loop-unrolling cases but it will only mean that it might still crash somewhere else outside of BCL.

We also expect nice diffs from OptRepeatCount alone (as well as massive throughput regressions due to SSA/VN re-computations).

@stephentoub
Copy link
Member

as well as massive throughput regressions

Well that doesn't sound ideal ;-)

@EgorBo
Copy link
Member

EgorBo commented Aug 15, 2023

as well as massive throughput regressions

Well that doesn't sound ideal ;-)

Yep, but maybe it might be allowed for some very specific cases or NativeAOT where we can afford slightly longer compilation 🙂

@hez2010
Copy link
Contributor Author

hez2010 commented Aug 15, 2023

Closing as not beneficial.

@hez2010 hez2010 closed this Aug 15, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Sep 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants