Skip to content

[wasm] Fix builds for blazor app + InvariantGlobalization=true#90432

Merged
radical merged 1 commit intodotnet:mainfrom
radical:wasm-fix-blazor
Aug 11, 2023
Merged

[wasm] Fix builds for blazor app + InvariantGlobalization=true#90432
radical merged 1 commit intodotnet:mainfrom
radical:wasm-fix-blazor

Conversation

@radical
Copy link
Member

@radical radical commented Aug 11, 2023 •
edited
Loading

The following commit caused workload to be required for a blazor app
when InvariantGlobalization==true, but this is not required.

commit 26ae09784c16dfa6707cd73eca2aeb00a28741d0
Author: Ankit Jain <[email protected]>
Date:   Thu Aug 10 23:39:10 2023 -0400

    [wasm] Fix up conditions to trigger relink, and require `wasm-tools` workload (#89754)

And this broke some sdk tests in dotnet/sdk#34522 .

Microsoft.NET.Sdk.BlazorWebAssembly.Tests.WasmPublishIntegrationTest.Publish_WithInvariantGlobalizationEnabled_DoesNotCopyGlobalizationData [FAIL]
    Expected command to pass but it did not.
    File Name: /datadisks/disk1/work/A6630924/p/d/dotnet
    Arguments: msbuild /t:Publish /datadisks/disk1/work/A6630924/w/AB7D09B1/e/testExecutionDirectory/Publish_WithI---129F25F8_2/blazorwasm-minimal.csproj /restore
    Exit Code: 1
    StdOut:
    MSBuild version 17.6.1+8ffc3fe3d for .NET
      Determining projects to restore...
    /datadisks/disk1/work/A6630924/p/d/sdk/8.0.100-ci/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.ImportWorkloads.targets(38,5): error NETSDK1147: To build this project, the following workloads must be installed: wasm-tools [/datadisks/disk1/work/A6630924/w/AB7D09B1/e/testExecutionDirectory/Publish_WithI---129F25F8_2/blazorwasm-minimal.csproj]
    /datadisks/disk1/work/A6630924/p/d/sdk/8.0.100-ci/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.ImportWorkloads.targets(38,5): error NETSDK1147: To install these workloads, run the following command: dotnet workload restore [/datadisks/disk1/work/A6630924/w/AB7D09B1/e/testExecutionDirectory/Publish_WithI---129F25F8_2/blazorwasm-minimal.csproj]
    StdErr:
    
    
      Stack Trace:
         at FluentAssertions.Execution.XUnit2TestFramework.Throw(String message)
         at FluentAssertions.Execution.TestFrameworkProvider.Throw(String message)
         at FluentAssertions.Execution.DefaultAssertionStrategy.HandleFailure(String message)
         at FluentAssertions.Execution.AssertionScope.FailWith(Func`1 failReasonFunc)
      /_/src/Tests/Microsoft.NET.TestFramework/Assertions/CommandResultAssertions.cs(29,0): at Microsoft.NET.TestFramework.Assertions.CommandResultAssertions.Pass()
      /_/src/Tests/Microsoft.NET.Sdk.BlazorWebAssembly.Tests/WasmPublishIntegrationTest.cs(1321,0): at Microsoft.NET.Sdk.BlazorWebAssembly.Tests.WasmPublishIntegrationTest.Publish_WithInvariantGlobalizationEnabled_DoesNotCopyGlobalizationData()
         at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
         at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

@radical
[wasm] Fix builds for blazor app + InvariantGlobalization=true
6b97efc 
The following commit caused workload to be required for a blazor app
when `InvariantGlobalization==true`, but this is not required.

```
commit 26ae097
Author: Ankit Jain <[email protected]>
Date:   Thu Aug 10 23:39:10 2023 -0400

    [wasm] Fix up conditions to trigger relink, and require `wasm-tools` workload (dotnet#89754)
```

And this broke some sdk tests.
@radical radical requested a review from lewing as a code owner August 11, 2023 21:44
@radical radical added the arch-wasm WebAssembly architecture label Aug 11, 2023
@ghost ghost added the area-Build-mono label Aug 11, 2023
@ghost ghost assigned radical Aug 11, 2023
@ghost
Copy link

ghost commented Aug 11, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

The following commit caused workload to be required for a blazor app
when InvariantGlobalization==true, but this is not required.

commit 26ae09784c16dfa6707cd73eca2aeb00a28741d0
Author: Ankit Jain <[email protected]>
Date:   Thu Aug 10 23:39:10 2023 -0400

    [wasm] Fix up conditions to trigger relink, and require `wasm-tools` workload (#89754)

And this broke some sdk tests.

Author: radical
Assignees: -
Labels:

arch-wasm
Milestone: -

@radical radical mentioned this pull request Aug 11, 2023
Merged
@radical radical merged commit 685b593 into dotnet:main Aug 11, 2023
@radical radical deleted the wasm-fix-blazor branch August 11, 2023 23:06
@ghost ghost locked as resolved and limited conversation to collaborators Sep 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@steveisok steveisok steveisok approved these changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@SteveSandersonMS SteveSandersonMS Awaiting requested review from SteveSandersonMS

@javiercn javiercn Awaiting requested review from javiercn

Assignees

@radical radical

Labels

arch-wasm WebAssembly architecture area-Build-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@radical @steveisok