Make CreateManifestAndDescriptors a nop for NativeRuntimeEventSource #90416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti Issue Details#86850 did work to make manifest generation cheaper for NativeRuntimeEventSource, but I'm not clear on why the answer wasn't instead to just not do anything for manifest generation for NativeRuntimeEventSource, which is what this PR does. On my machine, this lowers time-to-main by 33%, including removing all of the dynamic methods / JIT'ing work noted in #90405. @tommcdon, @davmason, @brianrob, am I missing something?
|
Member
Author
|
@brianrob informed me offline that this will break EventListeners. 😦 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#86850 did work to make manifest generation cheaper for NativeRuntimeEventSource, but I'm not clear on why the answer wasn't instead to just not do anything for manifest generation for NativeRuntimeEventSource, which is what this PR does.
On my machine, this lowers time-to-main by 33%, including removing all of the dynamic methods / JIT'ing work noted in #90405.
@tommcdon, @davmason, @brianrob, am I missing something?