Skip to content

[Blazor] Custom ICU loading from runtime path#90236

Merged
radical merged 15 commits intodotnet:mainfrom
ilonatommy:blazor-custom-icu-90018
Aug 14, 2023
Merged

[Blazor] Custom ICU loading from runtime path#90236
radical merged 15 commits intodotnet:mainfrom
ilonatommy:blazor-custom-icu-90018

Conversation

@ilonatommy
Copy link
Member

@ilonatommy ilonatommy commented Aug 9, 2023 •
edited
Loading

Fixes #90018

Blazor users can load custom files from full path or runtime pack files relative to runtime pack.

For follow up PR:
When adding a custom program code to Blazor WBT is done (see #89771 (review)): add code that runs globalization functions to test if globalization data is loaded correctly, like we do for WASM apps in WBT.

@ilonatommy ilonatommy added this to the 8.0.0 milestone Aug 9, 2023
@ilonatommy ilonatommy self-assigned this Aug 9, 2023
@ghost
Copy link

ghost commented Aug 9, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #90018

So far only point 1) is solved.

Author: ilonatommy
Assignees: ilonatommy
Labels:

arch-wasm, area-System.Globalization, area-Build-mono
Milestone: 8.0.0

@ilonatommy ilonatommy requested a review from maraf August 11, 2023 11:54
@build-analysis build-analysis bot mentioned this pull request Aug 11, 2023
Closed
3 tasks
@ilonatommy ilonatommy requested a review from maraf August 14, 2023 13:39
radical
radical reviewed Aug 14, 2023
View reviewed changes
@radical
Copy link
Member

radical commented Aug 14, 2023

https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-90236-merge-3aa70e9bc173453ba1/NoWorkload-Wasm.Build.Tests/1/console.58da26bb.log?helixlogtype=result

error MSB4044: The "FindInList" task was not given a value for the required parameter "ItemSpecToFind".

radical
radical reviewed Aug 14, 2023
View reviewed changes
radical
radical reviewed Aug 14, 2023
View reviewed changes
@radical radical merged commit 20d5e6e into dotnet:main Aug 14, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Sep 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pavelsavara pavelsavara pavelsavara left review comments

@radical radical radical approved these changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@maraf maraf Awaiting requested review from maraf maraf is a code owner

Assignees

@ilonatommy ilonatommy

Labels

arch-wasm WebAssembly architecture area-Build-mono area-System.Globalization

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

[Blazor] Custom ICU loading from runtime path

4 participants

@ilonatommy @radical @pavelsavara @maraf