[Blazor] Add basic ICU tests#89771
Merged
ilonatommy merged 22 commits intodotnet:mainfrom Aug 9, 2023
Merged
Conversation
ilonatommy
added
arch-wasm
|
Tagging subscribers to 'arch-wasm': @lewing Issue Details
For a follow-up PR:
|
|
Tagging subscribers to this area: @dotnet/area-system-globalization Issue Details
For a follow-up PR:
|
radical
reviewed
Aug 3, 2023
Member
radical
left a comment
radical
left a comment
There was a problem hiding this comment.
I'm guessing this needs a review after your other PR, that splits the tests, is merged.
src/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/AssetsComputingHelper.cs
Outdated
Show resolved
Hide resolved
src/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/AssetsComputingHelper.cs
Outdated
Show resolved
Hide resolved
3 tasks
radical
reviewed
Aug 8, 2023
radical
reviewed
Aug 8, 2023
radical
reviewed
Aug 8, 2023
radical
reviewed
Aug 8, 2023
radical
reviewed
Aug 8, 2023
radical
reviewed
Aug 8, 2023
radical
reviewed
Aug 8, 2023
radical
reviewed
Aug 8, 2023
radical
approved these changes
Aug 8, 2023
Member
radical
left a comment
radical
left a comment
There was a problem hiding this comment.
LGTM 👍 In a follow up we should expand the tests, and maybe try to re-use the ones we have for test-main.js . I will fix up our API to facilitate that.
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #89406.
First merge #89926, then this one.
LoadAllICUData->LoadFullICUData. "All" could mean "all data files" while we meant to say "data with full locales support".ShouldFilterCandidate).For a follow-up PR: #90018